KCM KWinVirtualDesktops disable UI when settings are immutable
AcceptedPublic

Authored by crossi on Tue, May 5, 8:52 AM.

Details

Reviewers
bport
meven
zzag
mart
Group Reviewers
KWin
Summary

When kcfg entries are set immutable [$i], disable the corresponding UI Item.

The Show animation when switching's checkbox consolidate all the effects listed in [Plugins],
consider if one is set to immutable enough to disable the entry in the UI.

Test Plan

All entries are located in kwinrc

  • To disable the modification of the desktops' list,
[Desktops]
Number[$i]=2
Rows[$i]=2
  • To disable the Options part
[Plugins]
cubeslideEnabled[$i]=true
desktopchangeosdEnabled[$i]=true

[Script-desktopchangeosd]
PopupHideDelay[$i]=800
TextOnly[$i]=true

[Windows]
RollOverDesktops[$i]=false

Diff Detail

Repository
R108 KWin
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 26371
Build 26389: arc lint + arc unit
crossi created this revision.Tue, May 5, 8:52 AM
Restricted Application added a project: KWin. · View Herald TranscriptTue, May 5, 8:52 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
crossi requested review of this revision.Tue, May 5, 8:52 AM
crossi updated this revision to Diff 81980.Tue, May 5, 8:54 AM

restore blank lines

crossi edited the summary of this revision. (Show Details)Tue, May 5, 9:12 AM
crossi edited the test plan for this revision. (Show Details)
crossi added reviewers: bport, meven, zzag, mart, KWin.
crossi edited the summary of this revision. (Show Details)Tue, May 5, 9:34 AM
meven accepted this revision.Tue, May 5, 10:32 AM
meven added inline comments.
kcmkwin/kwindesktop/package/contents/ui/main.qml
89

Is it really necessary to have !! ?

This revision is now accepted and ready to land.Tue, May 5, 10:32 AM
crossi added inline comments.Tue, May 5, 10:37 AM
kcmkwin/kwindesktop/package/contents/ui/main.qml
89

I had qml warnings stating that model is null, so I added this check.

zzag added inline comments.Tue, May 5, 2:50 PM
kcmkwin/kwindesktop/animationsmodel.h
34

I feel like this property belongs in EffectsModel.

60

s/isImmutableChanged/immutableChanged/