Don't use local URL for KMoreTool
ClosedPublic
Actions

Authored by broulik on May 5 2020, 7:45 AM.

Details

Reviewers

pdabrowski
elvisangelaccio

Group Reviewers

Dolphin

Commits

R318:9f268f5f76a4: Don't use local URL for KMoreTool

Summary

This method is called a billion times and spawns a blocking(!) StatJob.
KFind can search local URLs, too, so I don't see why this is necessary.
Either way, I'd rather have a non-KDE search tool broken than the app.
Ideally, I'd like this entire thing redone to use an async StatJob, if any.
Fwiw the KMoreTools in the free space bar doesn't use a local URL either.

BUG: 420911
FIXED-IN: 20.04.whateveristhenext

Test Plan

20.04

action still seems to work, kfind still starts

Diff Detail

Repository

R318 Dolphin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

broulik created this revision.May 5 2020, 7:45 AM

Restricted Application added a project: Dolphin. · View Herald TranscriptMay 5 2020, 7:45 AM

Restricted Application added a subscriber: kfm-devel. · View Herald Transcript

broulik requested review of this revision.May 5 2020, 7:45 AM

broulik edited the summary of this revision. (Show Details)

Fwiw the KMoreTools in the free space bar doesn't use a local URL either.

I have noticed this now. And this seems a sane thing to do.
Do Search or any search tools even work in remote locations?
"More Search Tools" menu doesn't cause #420911 in remote connections even though it is also called every time that menu is shown.