The deprecated ctor that took a KActionCollection param called the new
ctor (that doesn't take an actionCollection before) m_actionCollection was
assigned. This caused the menu actions never to get added to the
actionCollection as it was still nullptr. This caused crashes in
applications that still use the deprecated ctor, e.g. this bug in
konsole https://bugs.kde.org/show_bug.cgi?id=420820.
Since we can't assign m_actionCollection in the initializer list because
then the constructor delegation would follow a member initializer
(info courtsey of the compiler), introduce a helper init method to
reduce code duplication between the two ctor's.
Thanks to Friedrich W. H. Kossebau for figuring it out
https://phabricator.kde.org/D28800#663274.
CCBUG: 420820