Get rid of pixelation on HiDPI displays
ClosedPublic

Authored by yurchor on May 4 2020, 5:08 PM.

Details

Summary

KmPlot has a bad HiDPI support.

BUG: 419527

Test Plan
  1. Run "QT_SCALE_FACTOR=1.2 kmplot"
  2. Add a graph by clicking on "Create > Cartesian Plot" and enter f(x)=x^2

No pixelation should be observed.

Diff Detail

Repository
R334 KmPlot
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26344
Build 26362: arc lint + arc unit
yurchor created this revision.May 4 2020, 5:08 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptMay 4 2020, 5:08 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
yurchor requested review of this revision.May 4 2020, 5:08 PM
mthw added a subscriber: mthw.May 10 2020, 1:13 PM

This patch doesn't make a difference, the result is exactly the same.

Sad. Works fine locally on non-HiDPI display.

That means that the proposed by the bug reporter method of testing ("QT_SCALE_FACTOR=1.2 kmplot") does not work. We need a developer with a real HiDPI display.

cfeck added a comment.May 22 2020, 8:32 AM
In D29421#667522, @mthw wrote:

This patch doesn't make a difference, the result is exactly the same.

Could you please test (e.g. by adding qDebug() or printf()) if you are indeed running the kpart from the compiled kmplot instead of the one installed into the system?

alex added a subscriber: alex.May 22 2020, 8:46 AM

I quickly tested this, because I have a high DPI display and sometimes notice pixelated icons etc.
I didn't change any settings/had prior settings for this application.

Master branch (build from source):

With this patch:

In D29421#673387, @alex wrote:

I quickly tested this, because I have a high DPI display and sometimes notice pixelated icons etc.
I didn't change any settings/had prior settings for this application.

Many thanks for testing.

This revision was not accepted when it landed; it landed in state Needs Review.May 22 2020, 8:59 AM
This revision was automatically updated to reflect the committed changes.
mthw added a comment.May 22 2020, 7:34 PM
In D29421#667522, @mthw wrote:

This patch doesn't make a difference, the result is exactly the same.

Could you please test (e.g. by adding qDebug() or printf()) if you are indeed running the kpart from the compiled kmplot instead of the one installed into the system?

Looks like I wasn't. After removing installed kmplot and running the built one, everything works fine.