Use UI marker context in more tr() calls
ClosedPublic
Actions

Authored by kossebau on May 2 2020, 1:50 PM.

Details

Reviewers

Group Reviewers

Frameworks
Localization

Commits

R236:5904c475cb37: Use UI marker context in more tr() calls

Summary

Also fix some tooltip text styles to follow KDE HIG

Diff Detail

Repository

R236 KWidgetsAddons

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

kossebau created this revision.May 2 2020, 1:50 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptMay 2 2020, 1:50 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

kossebau requested review of this revision.May 2 2020, 1:50 PM

Harbormaster completed remote builds in B26234: Diff 81742.May 2 2020, 1:50 PM

Given the amounts of changes only to be applied directly after a KF tagging, to give translators as much time as possible to catch up.

also done for ui files

Harbormaster completed remote builds in B26235: Diff 81744.May 2 2020, 2:43 PM

The descriptions seem reasonable.

The problem with this is that it makes all strings untranslated and i'm not sure it's worth the effort.

My hope is that at this point anything that was actually ambiguous would have been reported by the translators and fixed. But i know that's a hope ^_^ more than a reality

So take this as a +0.1 i guess :D

Thanks Albert (& Luigi) for review. With no-one objecting, I would proceed to push this upcoming WE, 9/10th May, to be early in the cycle still.

This revision was not accepted when it landed; it landed in state Needs Review.May 8 2020, 11:51 PM

Closed by commit R236:5904c475cb37: Use UI marker context in more tr() calls (authored by kossebau). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/kactionselector.cpp (4 lines)
M			src/kassistantdialog.cpp (8 lines)
M			src/kcharselect.cpp (26 lines)
M			src/kcolorcombo.cpp (2 lines)
M			src/kdatepicker.cpp (16 lines)
M			src/kdatetimeedit.cpp (4 lines)
M			src/keditlistwidget.cpp (8 lines)
M			src/kfontchooser.cpp (12 lines)
M			src/kfontchooserdialog.cpp (2 lines)
M			src/kfontrequester.cpp (10 lines)
M			src/kmessagewidget.cpp (4 lines)
M			src/kmimetypechooser.cpp (14 lines)
M			src/knewpassworddialog.cpp (10 lines)
M			src/knewpasswordwidget.ui (6 lines)
M			src/kpassworddialog.cpp (2 lines)
M			src/kpassworddialog.ui (12 lines)
M			src/kpasswordlineedit.cpp (2 lines)
M			src/kpixmapregionselectordialog.cpp (4 lines)
M			src/kpixmapregionselectorwidget.cpp (6 lines)
M			src/ksqueezedtextlabel.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	81742	5d803a2		May 2 2020, 1:50 PM	★	★
Diff 2	81744	5d803a2	also done for ui files	May 2 2020, 2:43 PM	★	★
Diff 3	82326	2574582	R236:5904c475cb37919945867bb88d0945a54c4b08a1	May 8 2020, 11:51 PM	★	★