Differential D29219

[KFontChooser] Remove NoFixedCheckBox DisplayFlag, redundant
ClosedPublic
Actions

Authored by ahmadsamir on Apr 27 2020, 3:49 AM.

Details

Reviewers
dfaure
cfeck
bport
Group Reviewers
Frameworks
Commits
R236:5d803a237955: [KFontChooser] Remove NoFixedCheckBox DisplayFlag, redundant
Summary

This partially reverts 0004e5c89a248a508a; the NoFixedCheckBox flag is
redundant as just hiding the "show monospaced fonts only" checkbox when
the FixedFontsOnly flag is set is enough to handle the Konsole use case
(which was the primary reason that flag was introduced in the first place).
Since KF 5.70 isn't released yet, that flag can be safely removed; no
need to clutter the code with redundant flags, and more flags can be
added in the future if there's an actual need/use-case for them.

Thanks to Kurt Hindenburg for catching this,
https://invent.kde.org/kde/konsole/-/merge_requests/84

Test Plan

make && ctest

Diff Detail

Repository
R236 KWidgetsAddons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahmadsamir created this revision.Apr 27 2020, 3:49 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 27 2020, 3:49 AM
ahmadsamir requested review of this revision.Apr 27 2020, 3:49 AM
dfaure accepted this revision.Apr 27 2020, 9:10 AM
This revision is now accepted and ready to land.Apr 27 2020, 9:10 AM
Closed by commit R236:5d803a237955: [KFontChooser] Remove NoFixedCheckBox DisplayFlag, redundant (authored by ahmadsamir). · Explain WhyApr 27 2020, 9:35 AM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 3 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 81317