Status bar: Hide the space free bar when size is unknown
ClosedPublic

Authored by meven on Apr 26 2020, 7:13 PM.

Details

Summary

BUG: 420027
BUG: 422226
FIXED-IN: 20.08

Test Plan

Diff Detail

Repository
R318 Dolphin
Branch
arcpatch-D29213
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26761
Build 26779: arc lint + arc unit
meven created this revision.Apr 26 2020, 7:13 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptApr 26 2020, 7:13 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
meven requested review of this revision.Apr 26 2020, 7:13 PM
meven edited the test plan for this revision. (Show Details)Apr 26 2020, 7:14 PM

Why not hide the entire widget?

meven added a comment.Apr 26 2020, 9:08 PM

Why not hide the entire widget?

I am concerned users could confuse the space bar and the zoom boom, if we remove the space bar.
Plus it would look weird when the space bar hides/shows.

The bad thing though is that the progress does not use more space when there is no text to show.

What about "Size not available" ? I'm not sure I like the empty space there...

I would be in favor of either hiding the widget as @broulik suggests entirely or showing a placeholder string as @elvisangelaccio suggests.

meven added a comment.Apr 28 2020, 7:43 AM

I would be in favor of either hiding the widget as @broulik suggests entirely or showing a placeholder string as @elvisangelaccio suggests.

I will have to try both as there is not clearly favored solution, and I don't have a favorite either.

But "Size not available" sounds a lot like "Unknown size".

Perhaps with the no text option or "Size not available" we could disabled the widget to get it greyer and more obvious it does not work.

Sounds to me like we should just hide the widget entirely when there's no size available, or a size calculation doesn't make sense given the context.

Sounds to me like we should just hide the widget entirely when there's no size available, or a size calculation doesn't make sense given the context.

+1

meven retitled this revision from Status bar: display no text when no free space size in unkwown to Status bar: Hide the space free bar when size in unkwown.May 12 2020, 7:14 AM
meven edited the test plan for this revision. (Show Details)
meven updated this revision to Diff 82630.May 12 2020, 7:15 AM

Hide spaceBarSpaceInfo when size is unknwown

+1, though I see a brief flicker of the widget when I switch between two views where it's hidden, such as recentlyused:/files/ and recentlyused:/locations/ can you reproduce?

meven added a comment.May 13 2020, 2:58 PM

+1, though I see a brief flicker of the widget when I switch between two views where it's hidden, such as recentlyused:/files/ and recentlyused:/locations/ can you reproduce?

I thinks this is easily fixable.
Waiting for m_observer slotValuesChanged() before showing the widget.

meven updated this revision to Diff 83173.May 29 2020, 5:14 PM

A a shown and ready bool to manage the state of the statusbarspaceinfo

meven added a comment.May 29 2020, 5:15 PM

+1, though I see a brief flicker of the widget when I switch between two views where it's hidden, such as recentlyused:/files/ and recentlyused:/locations/ can you reproduce?

No more flikckering with latest update ;)

ngraham retitled this revision from Status bar: Hide the space free bar when size in unkwown to Status bar: Hide the space free bar when size is unknown.May 29 2020, 5:25 PM
ngraham accepted this revision.May 29 2020, 5:49 PM

LGTM

This revision is now accepted and ready to land.May 29 2020, 5:49 PM
meven edited the summary of this revision. (Show Details)May 30 2020, 10:00 AM
meven edited the summary of this revision. (Show Details)May 30 2020, 11:29 AM
src/statusbar/statusbarspaceinfo.h
65 ↗(On Diff #83173)

Please use m_ prefix also for this variable.

meven updated this revision to Diff 83187.Jun 1 2020, 5:43 AM

Rename member field to m_ready

meven marked an inline comment as done.Jun 1 2020, 5:43 AM
meven added a comment.Jun 1 2020, 8:49 AM

Will merge soonish if @elvisangelaccio has nothing to say

elvisangelaccio accepted this revision.Jun 7 2020, 10:01 PM
meven closed this revision.Jun 8 2020, 5:49 AM