BUG: 420027
BUG: 422226
FIXED-IN: 20.08
Details
- Reviewers
ngraham broulik elvisangelaccio - Group Reviewers
Dolphin VDG - Commits
- R318:bf4388c75525: Status bar: Hide the space free bar when size is unknown
Diff Detail
- Repository
- R318 Dolphin
- Branch
- arcpatch-D29213
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 26761 Build 26779: arc lint + arc unit
I am concerned users could confuse the space bar and the zoom boom, if we remove the space bar.
Plus it would look weird when the space bar hides/shows.
The bad thing though is that the progress does not use more space when there is no text to show.
I would be in favor of either hiding the widget as @broulik suggests entirely or showing a placeholder string as @elvisangelaccio suggests.
I will have to try both as there is not clearly favored solution, and I don't have a favorite either.
But "Size not available" sounds a lot like "Unknown size".
Perhaps with the no text option or "Size not available" we could disabled the widget to get it greyer and more obvious it does not work.
Sounds to me like we should just hide the widget entirely when there's no size available, or a size calculation doesn't make sense given the context.
+1, though I see a brief flicker of the widget when I switch between two views where it's hidden, such as recentlyused:/files/ and recentlyused:/locations/ can you reproduce?
I thinks this is easily fixable.
Waiting for m_observer slotValuesChanged() before showing the widget.
src/statusbar/statusbarspaceinfo.h | ||
---|---|---|
65 ↗ | (On Diff #83173) | Please use m_ prefix also for this variable. |