Make the Focus capture action include star detection
ClosedPublic

Authored by TallFurryMan on Apr 22 2020, 3:05 PM.

Details

Summary

This differential makes the Focus capture button state reflect exposure and detection.
Before that change, the capture button reverted to the enable state after the frame was received but the source extraction continued in the background.
The UI was therefore ready to accept user input, but at the same time unresponsive.
The differential adjusts the UI tests to wait for the capture button to re-enable, instead of inserting a suitable delay before waiting.

This differential also replaces an assertion generated when the tracking box is enabled in full-field detection, with an immediate disable of the tracking box.
This differential also rewrites the tooltip displayed by the detection method drop-down, providing more detailed information.
This differential also fixes the explicit assignment operator warnings.

Test Plan

UI tests through kstars_ui_tests. Jenkins builds for warnings.

Diff Detail

Repository
R321 KStars
Branch
improve__determine_star_detection_end (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 25711
Build 25729: arc lint + arc unit
TallFurryMan created this revision.Apr 22 2020, 3:05 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptApr 22 2020, 3:05 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
TallFurryMan requested review of this revision.Apr 22 2020, 3:05 PM
  • Add a longer exposure test, add a delay based on required exposure frames, check stop button immediately.
  • Remove remaining reference to BZ398192, adjust timeouts.
  • Merge branch 'master' into improve__determine_star_detection_end

This is complete and ready to review.

kstars/tools/modcalcvizequinox.cpp
381

This is from kstars PR#22.

murveit accepted this revision.Apr 27 2020, 6:58 AM

Looks good. Thanks!

This revision is now accepted and ready to land.Apr 27 2020, 6:58 AM
mutlaqja accepted this revision.Apr 27 2020, 7:04 AM
This revision was automatically updated to reflect the committed changes.