Make the Focus capture action include star detection

Authored by TallFurryMan on Apr 27 2020, 7:05 AM.

Description

Make the Focus capture action include star detection

Summary:
This differential makes the Focus capture button state reflect exposure and detection.
Before that change, the capture button reverted to the enable state after the frame was received but the source extraction continued in the background.
The UI was therefore ready to accept user input, but at the same time unresponsive.
The differential adjusts the UI tests to wait for the capture button to re-enable, instead of inserting a suitable delay before waiting.

This differential also replaces an assertion generated when the tracking box is enabled in full-field detection, with an immediate disable of the tracking box.
This differential also rewrites the tooltip displayed by the detection method drop-down, providing more detailed information.
This differential also fixes the explicit assignment operator warnings.

Test Plan: UI tests through kstars_ui_tests. Jenkins builds for warnings.

Reviewers: KStars, mutlaqja, murveit

Reviewed By: KStars, mutlaqja, murveit

Subscribers: kde-edu

Tags: KDE Edu

Differential Revision: https://phabricator.kde.org/D29099