Differential D29097

Adapt FindKF5 to stricter checks in newer find_package_handle_standard_args
ClosedPublic
Actions

Authored by kossebau on Apr 22 2020, 1:43 PM.

Details

Reviewers
krop
Group Reviewers
Frameworks
Build System
Commits
R240:ebc874095b4d: Adapt FindKF5 to stricter checks in newer find_package_handle_standard_args
Test Plan

KF modules configure build as before, same some apps.

Diff Detail

Repository
R240 Extra CMake Modules
Branch
avoidnewwarningsinfindkf5
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 25688
Build 25706: arc lint + arc unit
kossebau created this revision.Apr 22 2020, 1:43 PM
Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptApr 22 2020, 1:43 PM
Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. · View Herald Transcript
kossebau requested review of this revision.Apr 22 2020, 1:43 PM
kossebau added a comment.Apr 22 2020, 1:45 PM

Warning: I have not really investigated in full detail if the current code of FindKF5 is completely sane besides a quick check, more or less assume that it has worked all the time, so the new warning here can be silenced.

krop accepted this revision.Apr 22 2020, 1:55 PM
This revision is now accepted and ready to land.Apr 22 2020, 1:55 PM
apol added a subscriber: apol.Apr 22 2020, 3:05 PM

+1 makes sense

Closed by commit R240:ebc874095b4d: Adapt FindKF5 to stricter checks in newer find_package_handle_standard_args (authored by kossebau). · Explain WhyApr 22 2020, 4:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mfind-modules/FindKF5.cmake (7 lines)

Diff 80884

View Options

find-modules/FindKF5.cmake

Loading...