[QStyle] Make menu titles look less like menu items
ClosedPublic

Authored by ngraham on Apr 22 2020, 5:19 AM.

Details

Summary

The look of Breeze menu titles has always slightly bothered me since they have the same
visual style and weighting as items, so they look clickable even though they aren't, and
they don't really do a very good job of separating sections, as seems to be their purpose.
This patch my my attempt to remedy the situation by making them look more "title-like"
and have greater visual distinctiveness from the items above and below them.

Test Plan

Plasma Task Manager item context menu, before:


Plasma Task Manager context menu, after:

KMoreTools menu, before:


KMoreTools menu, after:

Diff Detail

Repository
R31 Breeze
Branch
menu-title-looks-less-like-a-menu-item (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 27027
Build 27045: arc lint + arc unit
ngraham created this revision.Apr 22 2020, 5:19 AM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 22 2020, 5:19 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Apr 22 2020, 5:19 AM

Not a fan of making it hard to read. I agree that it makes it more obvious it's not clickable but we deliberately changed many places that used disabled menu items as sections to use proper sections for readability.

Not a fan of making it hard to read. I agree that it makes it more obvious it's not clickable but we deliberately changed many places that used disabled menu items as sections to use proper sections for readability.

That's true.

Do you think we should try to mimic the Kirigami ListSectionHeader appearance then?

ngraham updated this revision to Diff 80924.Apr 22 2020, 6:21 PM

Make the title look more like Kirigami section separators

ngraham edited the test plan for this revision. (Show Details)Apr 22 2020, 6:22 PM
niccolove accepted this revision as: niccolove.May 6 2020, 7:57 PM
niccolove added a subscriber: niccolove.

VDG wise, this looks good and consistent.

This revision is now accepted and ready to land.May 6 2020, 7:57 PM
ndavis requested changes to this revision.May 6 2020, 7:58 PM
ndavis added a subscriber: ndavis.

Big +1 to the idea, but this shouldn't use darker() because that won't look right in Breeze Dark.

This revision now requires changes to proceed.May 6 2020, 7:58 PM
ngraham planned changes to this revision.May 6 2020, 8:07 PM

I messed up the rounded top corner too. Will revise.

cfeck added a subscriber: cfeck.May 6 2020, 8:09 PM

What a small difference that makes such a large difference!

cfeck added a comment.May 6 2020, 8:12 PM

Instead of darker, you could use the text color with very small alpha.

cblack added a subscriber: cblack.May 6 2020, 8:15 PM

Big +1 to the idea, but this shouldn't use darker() because that won't look right in Breeze Dark.

Personally, I think this will look fine when always using darker().

ndavis added a comment.May 6 2020, 8:22 PM

Big +1 to the idea, but this shouldn't use darker() because that won't look right in Breeze Dark.

Personally, I think this will look fine when always using darker().

It's not consistent with how breeze dark normally works though.

ngraham updated this revision to Diff 83065.May 19 2020, 4:50 PM

Fix non-rounded corners

ngraham updated this revision to Diff 83066.May 19 2020, 4:58 PM

Compute background color in a more colorscheme-friendly way

ndavis accepted this revision.May 19 2020, 5:19 PM
This revision is now accepted and ready to land.May 19 2020, 5:19 PM
ngraham closed this revision.May 19 2020, 5:24 PM