Depends on: D29054
Details
Details
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Lint
Lint Skipped - Unit
Unit Tests Skipped - Build Status
Buildable 25969 Build 25987: arc lint + arc unit
Comment Actions
I would rather prefer plasma_window to have a stacking order property so the plasma window management interface stays well encapsulated and to avoid using yet another type of window ids.
Feel free to push this change if others are okay with it.
| abstract_client.h | ||
|---|---|---|
| 875 | Toplevel has already a property named internalId. I suggest to avoid using internalId. What about adding a m_windowManagementInterface accessor? | |
| wayland_server.cpp | ||
| 496–498 | How's this possible? | |
Comment Actions
I would rather prefer plasma_window to have a stacking order property so the plasma window management interface stays well encapsulated and to avoid using yet another type of window ids.
The problem is that having that as the wire communication is that it's racey.
So assuming then we want this atomic list - I don't see a neat way to have the list, but not expose either windowInternalId or PlasmaWindow* from AbstractClient.
Comment Actions
Expose plasma window management interface instead of internal id to avoid another window id exposed
On X we don't have this atomicity, so we can go to PlasmaWindow stacking order property without any regression.
However I think atomicity can prevent bug on future use.
| wayland_server.cpp | ||
|---|---|---|
| 496 |
for (Toplevel *toplevel : workspace()->stackingOrder()) { auto client = qobject_cast<AbstractClient *>(toplevel); // ... } | |