This commits adds checks of m_log variable contains anything before using it.
More appropriate is not showing 'SVN Log...' as available action at all, this should go in a further commits.
Anyway checks for a m_log variable is a must.
Details
Details
- Reviewers
meven elvisangelaccio - Group Reviewers
Dolphin - Commits
- R449:c64770b95b6b: Fix 'SVN Log...' crash while watching history in the unversioned directory.
Run 'SVN Log...' in unversioned directory make sure it doesn't crash any more and showes empty history.
Diff Detail
Diff Detail
- Repository
- R449 Plugins for Dolphin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
I would have updated static QSharedPointer< QVector<logEntry> > getLog(const QString& filePath, uint maxEntries = 255, ulong fromRevision = 0); to match its documentation instead
Comment Actions
Can you please explain what do you mean? The documentation is also fixed and i think is correct now.
Comment Actions
Returning an empty QVector instead of null in getLog would have sufficed and would be somewhat safer as the documentation suggested it did, but didn't.
Anyway that's not very important.
Comment Actions
True, but there is one case where empty history is not an error: just created repository.
Returning a nullptr covers this case.
Comment Actions
@meven i pushed this myself as everyone accepted it but commit is missing at the github mirror https://github.com/KDE/dolphin-plugins
i did something wrong?
Comment Actions
It is here source of truth is cgit.kde.org (soon to be invent.kde.org)
https://cgit.kde.org/dolphin-plugins.git/commit/?id=c64770b95b6b52e5fd7d74452477fca612fb22d3
The mirroring probably just lags a little.