Use Q_EMIT and build with QT_NO_KEYWORDS
ClosedPublic
Actions

Authored by junghans on Apr 20 2020, 6:56 AM.

Details

Reviewers

kossebau
dfaure
apol

Commits

R275:b066824b5e2f: Use Q_EMIT and build with QT_NO_KEYWORDS

Summary

QT_NO_KEYWORDS will be default in Qt 6 so all occurrences of emit should be replaced by Q_EMIT.

Test Plan

Build with QT_NO_KEYWORDS define enabled and observe succesful build.

Diff Detail

Repository

R275 KItemModels

Lint

Lint Skipped

Unit

Unit Tests Skipped

junghans created this revision.Apr 20 2020, 6:56 AM

Restricted Application added a project: Frameworks. · View Herald TranscriptApr 20 2020, 6:56 AM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

junghans requested review of this revision.Apr 20 2020, 6:56 AM

We should also have a task on the KF6 workboard[1] about this, so that we cull them out of all the current code in KDE.

(Or maybe use a perl-script to get them all?)

[1] https://phabricator.kde.org/project/board/310/

apol accepted this revision.Apr 20 2020, 10:46 AM

This revision is now accepted and ready to land.Apr 20 2020, 10:46 AM

The initial diff was incomplete. This one covers all occurrences of Q_EMIT.

dfaure accepted this revision.Apr 22 2020, 1:09 PM

@junghans Hi. Do you have push rights, or do you need someone to merge your patch?

Looking at D28915, seems you are only collecting to earn push rights so far :), so going to push for you with the author info taken from there.

kossebau closed this revision.May 25 2020, 11:24 PM

Thank you for committing! Although I recently gained push rights, I did not have time yet to dig into the details of how to create/push commit respecting the KDE standards etc. Next time, I'll try on my own :)

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (1 line)
M			autotests/proxymodeltestsuite/dynamictreemodel.cpp (8 lines)
M			src/core/kcheckableproxymodel.cpp (6 lines)
M			src/core/kconcatenaterowsproxymodel.cpp (6 lines)
M			src/core/kdescendantsproxymodel.cpp (16 lines)
M			src/core/kextracolumnsproxymodel.cpp (6 lines)
M			src/core/knumbermodel.cpp (8 lines)
M			src/core/kselectionproxymodel.cpp (32 lines)
M			tests/proxymodeltestapp/kreparentingproxymodel.cpp (10 lines)
M			tests/proxymodeltestapp/lessthanwidget.cpp (2 lines)