Use Q_EMIT and build with QT_NO_KEYWORDS
ClosedPublic

Authored by junghans on Apr 20 2020, 6:56 AM.

Details

Summary

QT_NO_KEYWORDS will be default in Qt 6 so all occurrences of emit should be replaced by Q_EMIT.

Test Plan

Build with QT_NO_KEYWORDS define enabled and observe succesful build.

Diff Detail

Repository
R275 KItemModels
Lint
Lint Skipped
Unit
Unit Tests Skipped
junghans created this revision.Apr 20 2020, 6:56 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 20 2020, 6:56 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
junghans requested review of this revision.Apr 20 2020, 6:56 AM
ahmadsamir added a subscriber: ahmadsamir.

We should also have a task on the KF6 workboard[1] about this, so that we cull them out of all the current code in KDE.

(Or maybe use a perl-script to get them all?)

[1] https://phabricator.kde.org/project/board/310/

apol accepted this revision.Apr 20 2020, 10:46 AM
This revision is now accepted and ready to land.Apr 20 2020, 10:46 AM
junghans updated this revision to Diff 80852.Apr 22 2020, 8:57 AM

The initial diff was incomplete. This one covers all occurrences of Q_EMIT.

dfaure accepted this revision.Apr 22 2020, 1:09 PM

@junghans Hi. Do you have push rights, or do you need someone to merge your patch?

Looking at D28915, seems you are only collecting to earn push rights so far :), so going to push for you with the author info taken from there.

kossebau closed this revision.May 25 2020, 11:24 PM

Thank you for committing! Although I recently gained push rights, I did not have time yet to dig into the details of how to create/push commit respecting the KDE standards etc. Next time, I'll try on my own :)