Builds, but untested.
Details
Diff Detail
- Repository
- R114 Plasma Addons
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 25473 Build 25491: arc lint + arc unit
Since it's an applet and thus run inside Plasma, do we not rather want the KNotificationJobUiDelegate?
Also actually this should probably be refactored completely to use KServiceAction rather passing the exec to QML and then back here :)
Agreed about notification delegate, will do.
Does this really use KServiceAction anywhere? I don't see that. Confusing this one and D28988? [which however can't use the KServiceAction because of special support for %D and stuff]
Does this really use KServiceAction anywhere?
It doesn't but it should since it also supports jump list ations. Probably needs similar treatment like I did with task manager in D28286
OK, that's above my head. Shall I push this or you'll rework it all?
I just want to be able to deprecated KRun::run and friends :)
If you want to rework it that'll be appreciated but I can look into it since I did the pioneer porting of Task manager