Differential D28972

FileMetaDataWidget: Avoid showing fields when they have no value
ClosedPublic
Actions

Authored by meven on Apr 19 2020, 6:42 AM.

Details

Reviewers
ngraham
bruns
Group Reviewers
Dolphin
Commits
R824:44c4f46b584b: FileMetaDataWidget: Avoid showing fields when they have no value
Summary

When displaying remote:/ recentlyused:/, Search:/ or and Tags:/, the information panel shows modifications time, access time and size with empty field value.
This patches avoids displaying those fields when we have no value for them.

CCBUG: 413091
More precisely https://bugs.kde.org/show_bug.cgi?id=413091#c7

Test Plan

Open remote:/ in Dolphin:
Size, Access and modification dates fields are not visible

Diff Detail

Repository
R824 Baloo Widgets
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 25450
Build 25468: arc lint + arc unit
meven created this revision.Apr 19 2020, 6:42 AM
Restricted Application added a project: Baloo. · View Herald TranscriptApr 19 2020, 6:42 AM
Restricted Application added a subscriber: Baloo. · View Herald Transcript
meven requested review of this revision.Apr 19 2020, 6:42 AM
ngraham accepted this revision.Apr 19 2020, 11:19 PM
ngraham added a reviewer: bruns.
This revision is now accepted and ready to land.Apr 19 2020, 11:19 PM
meven added a comment.Apr 25 2020, 7:52 PM

@bruns does this sounds good to you ?

bruns added a comment.Apr 25 2020, 8:04 PM
In D28972#657192, @meven wrote:

@bruns does this sounds good to you ?

The code looks fine. Can you extend the summary so it is immediately visible where this is needed/useful, without having to folllow the bug link?

meven added a comment.Apr 25 2020, 8:09 PM
In D28972#657193, @bruns wrote:
In D28972#657192, @meven wrote:

@bruns does this sounds good to you ?

The code looks fine. Can you extend the summary so it is immediately visible where this is needed/useful, without having to folllow the bug link?

The test plan showed succinctly what the diff accomplished I think.
I will improve the comment still.

meven edited the summary of this revision. (Show Details)Apr 25 2020, 8:10 PM
bruns added a comment.Apr 25 2020, 8:11 PM

Wrap at ~80 characters, please.

bruns accepted this revision.Apr 25 2020, 8:11 PM
meven retitled this revision from FileMetaDataWidget: Avoid displaying size and dates fields when they have no value to FileMetaDataWidget: Avoid fields when they have no value.Apr 25 2020, 8:11 PM
meven retitled this revision from FileMetaDataWidget: Avoid fields when they have no value to FileMetaDataWidget: Avoid showing fields when they have no value.
meven edited the summary of this revision. (Show Details)Apr 25 2020, 8:13 PM
Closed by commit R824:44c4f46b584b: FileMetaDataWidget: Avoid showing fields when they have no value (authored by meven). · Explain WhyApr 25 2020, 8:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/filemetadataprovider.cpp (20 lines)

Diff 80518

View Options

src/filemetadataprovider.cpp

Loading...