Differential D2894

Start KDE Cleanups
ClosedPublic
Actions

Authored by davidedmundson on Sep 30 2016, 2:58 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R871:bc1324ceebbd: Start KDE Cleanups
R120:bc1324ceebbd: Start KDE Cleanups
Summary

Remove outdated parts of startkde that are no longer used

Remove setion about kwin_failsafe which isn't used
Remove code related to oxygen fonts that aren't used
Remove section about darwin
Get rid of check that dbus-server exists, it autostarts
Don't try to set $qdbus to a path to qdbus... it wasn't used
conherently, so we don't really need it

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson updated this revision to Diff 7005.Sep 30 2016, 2:58 PM
davidedmundson retitled this revision from to Start KDE Cleanups.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptSep 30 2016, 2:58 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik added a subscriber: broulik.Sep 30 2016, 3:19 PM
broulik added inline comments.
startkde/startkde.cmake
6

Don't we install an "kde failsafe" x session which uses that?

153

Is that see still needed/correct with generic config location?

davidedmundson added inline comments.Sep 30 2016, 3:28 PM
startkde/startkde.cmake
6

We did in KDE4, I can't see it in plasma-workspace now though
The only file to go to /usr/share/xsessions is plasma.desktop and that has no mention of failsafe

153

Yes.

David-Desktop:~/projects/kde5/src/kde/workspace $ qtpaths --paths GenericConfigLocation
/home/david/.config:/opt/kde5/etc/xdg::/etc/xdg

David-Desktop:~/projects/kde5/src/kde/workspace $ qtpaths --paths ConfigLocation
/home/david/.config:/opt/kde5/etc/xdg::/etc/xdg

The change doens't actually acheive much

So we still need the tr and sed to turn it into

/home/david/.config/plasma-workspace
/opt/kde5/etc/xdg/plasma-workspace
/etc/xdg/plasma-workspace

davidedmundson added inline comments.Sep 30 2016, 3:35 PM
startkde/startkde.cmake
153

Edit!

I can make this better. See next patch

davidedmundson updated this revision to Diff 7007.Sep 30 2016, 3:37 PM

Cleanup qtpaths

mart added a subscriber: mart.Oct 6 2016, 9:34 AM

what's the status on that?

davidedmundson added a comment.Oct 6 2016, 9:54 AM
In D2894#54881, @mart wrote:

what's the status on that?

Done in the second patch.

mart added a comment.Oct 6 2016, 9:59 AM
In D2894#54900, @davidedmundson wrote:
In D2894#54881, @mart wrote:

what's the status on that?

Done in the second patch.

so this should be good to go?

davidedmundson added a comment.Oct 6 2016, 10:00 AM
In D2894#54911, @mart wrote:
In D2894#54900, @davidedmundson wrote:
In D2894#54881, @mart wrote:

what's the status on that?

Done in the second patch.

so this should be good to go?

Well I think so..just waiting on approval

mart accepted this revision.Oct 6 2016, 10:20 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Oct 6 2016, 10:20 AM
Closed by commit R120:bc1324ceebbd: Start KDE Cleanups (authored by davidedmundson). · Explain WhyOct 7 2016, 12:19 AM
This revision was automatically updated to reflect the committed changes.
wbauer added a subscriber: wbauer.Nov 2 2016, 5:36 PM
wbauer added inline comments.
startkde/startkde.cmake
295

$qdbus is still being used here, so this won't work anymore I suppose...

Revision Contents
Changeset List

PathPackages
Mstartkde/startkde.cmake (77 lines)

Diff 7172

View Options

startkde/startkde.cmake

Loading...