Drop delayed second phase
ClosedPublic

Authored by broulik on Apr 17 2020, 1:42 PM.

Details

Summary

kded runs Phase 0 and Phase 1 on startup and then plasma-session Startup calls Phase 2 somewhere around the end of startup.
Investigation and testing shows this has little effect on startup, if any, makes it slower.
More importantly, it complicates startup and makes it harder to recreate the startup sequence as systemd units.

Test Plan
  • All services are still started
  • @davidedmundson did some bootchart that showed startup is actually faster without this

Also refer to my lovely table of services we start: T12616

Diff Detail

Repository
R297 KDED
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 17 2020, 1:42 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 17 2020, 1:42 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Apr 17 2020, 1:42 PM

@davidedmundson did some bootchart that showed startup is actually faster without this

It was probably just noise as it wasn't a full average of N tests, just 2 clean boots. However ksplash removed 100ms earlier. I can attach if needed.

As for the patch, +1

apol accepted this revision.Apr 17 2020, 3:13 PM
apol added a subscriber: apol.

Makes sense, sounds like the second phase is quite arbitrary there.

This revision is now accepted and ready to land.Apr 17 2020, 3:13 PM
broulik requested review of this revision.Apr 20 2020, 7:32 AM

Waiting for @dfaure

dfaure accepted this revision.Apr 20 2020, 7:37 AM

I trust your analysis ;)

This revision is now accepted and ready to land.Apr 20 2020, 7:37 AM
This revision was automatically updated to reflect the committed changes.