you need to add the change to holidays.qrc to this patch

Now you're missing holidays/plan2/holiday_tw_zh which can still be seen here: https://phabricator.kde.org/D28874?id=80260

git add holidays/holidays.qrc
git add holidays/plan2/holiday_tw_zh
git diff --staged > D28874.diff

problems:

• "religous" should be "religious"
• missing ':' at the start of Constitution Day
  • missing ':' at the start of Christmas Day

There's a few extra spaces at the end of "植樹節 " and "中秋節 補假 " too.

Not sure how well you know git, but make sure to run git add holidays/plan2/holiday_tw_zh again after making your changes, before running git diff --staged to upload the modified diff.

Phab only understands .diff. Phab does not recognize .patch.

git diff --staged > D28874.diff

Or:

git diff origin/master > D28874.diff

remove holidays/0001-added-holiday_tw_zh-and-updated-holiday.qrc.patch

Do you not have commit access? I thought you were the maintainer based on the repo's history!

In D28874#650661, @ngraham wrote:

Do you not have commit access? I thought you were the maintainer based on the repo's history!

Yes of course.
I'm asking for assistance at this time.

Sure, I can do it.

Thank you for your attempt to add Taiwanese holidays to KDE. However, I am afraid that this patch has to be reviewed again.

The dates for some holidays (including, but not limited to, Spring Festival (also known as "Lunar New Year") and the Mid-Autumn Festival) are different every year because some holidays are determined based on the Lunar Calendar (農曆). That means one has to specify the exact dates for each year, just like the holiday_hk_* files.
If you look at the table in the English Wikipedia entry for Public holidays in Taiwan carefully, you will notice that some holidays follow Chinese calendar instead of the Gregorian calendar.

Therefore, we should try to refer to the relevant laws and regulations, and use government-published documents as sources for accuracy. In this case, we should refer to the law "紀念日及節日實施辦法" (only available in Chinese). In addition, the Ministry of the Interior, R. O. C. (Taiwan) publishes a document listing the exact dates of public holidays each year ("public" here means "放假", carrying the meaning of being a day off). The document for 2020 can be found here (Note that the ROC era is used, so Year 109 means 2020).

The public holidays as well as the official commemorative holidays are already complicated, so I think for the time being it would be better to exclude non-official holidays such as Halloween or Christmas.

Thank you for your attention.

By the way, the holiday file for People's Republic of China (i.e. mainland China) also needs update too because the dates of Lunar calendar based holidays are only available for 2009.
The comment in the file says "these have to wait for lunar calendar support", but it looks like Qt and KDE have yet to support Lunar calendar, so we have to update the dates manually for the time being.

I will see whether I can update the holiday files for both Taiwan and mainland China to make them more accurate.

I just wanted to say thank you to everybody for taking the time. Taiwan is available in the clock/calendar settings now, really cool!