Split out from D24443.
Adds meta information for display by applications that show the calendar.
Ideally we'd use QIcon for the icon instead of an iconname string, but that would require linking against QtGui.
vkrause | |
winterz |
Frameworks | |
KDE PIM |
Split out from D24443.
Adds meta information for display by applications that show the calendar.
Ideally we'd use QIcon for the icon instead of an iconname string, but that would require linking against QtGui.
builds
No Linters Available |
No Unit Test Coverage |
Buildable 25239 | |
Build 25257: arc lint + arc unit |
looks good.
nice touch using Q_EMIT.
src/calendar_p.h | ||
---|---|---|
81 | CalendarType mType = ReadWrite ? |
I don't know how things are done in frameworks but it seems to me that the KF5_VERSION (see top of kcalendarcore/CMakeLists.txt) needs to become 5.70.0 now
This is handled automatically, no need to change this.
src/calendar.h | ||
---|---|---|
101 | As already noted in the previous review, "type" isn't the best naming for something that is about access control/permission IMHO. A possible alternative name could be something like "AccessMode", or maybe even just bool isReadOnly. |