Add note about porting loadMimeTypeIcon
ClosedPublic

Authored by nicolasfella on Apr 14 2020, 3:12 PM.

Details

Summary

We're phasing out loadMimeTypeIcon in favor of QIcon::fromTheme(). We can't oficially deprecate it yet since there are still unported users, but add a comment recommending alternative API.

Diff Detail

Repository
R302 KIconThemes
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Apr 14 2020, 3:12 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 14 2020, 3:12 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.Apr 14 2020, 3:12 PM
dfaure accepted this revision.Apr 14 2020, 8:36 PM

OK, for the simple case (no overlays, no extraction of path). More complete documentation would include the args for QIcon::pixmap but OK, very often we just port to QIcon instead.

This revision is now accepted and ready to land.Apr 14 2020, 8:36 PM
This revision was automatically updated to reflect the committed changes.