Instead of skipping generating previews on encrypted filesystems, do create them but don't cache.
BUG: 411919
FIXED-IN: 5.70
Details
Details
- Reviewers
ivan dfaure ngraham - Group Reviewers
Frameworks - Commits
- R241:ae0beded1fd9: Show previews on encrypted filesystems
Diff Detail
Diff Detail
- Repository
- R241 KIO
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
General idea looks sane to me. Thanks for working on this; it's been one of those minor annoyances of mine.
| src/widgets/previewjob.cpp | ||
|---|---|---|
| 718 ↗ | (On Diff #79991) | unrelated change |
Comment Actions
Works and looks good to me modulo one comment, but let's wait for the other reviewers too.
| src/widgets/previewjob.cpp | ||
|---|---|---|
| 692 | const | |
| src/widgets/previewjob.cpp | ||
|---|---|---|
| 697 ↗ | (On Diff #79985) | Since you are already changing this, move these two checks to the line after bSave - short-circuit logic to skip calling ->property and the rest if these two are not satisfied. |
| src/widgets/previewjob.cpp | ||
|---|---|---|
| 307 ↗ | (On Diff #79985) | "for which will be used" ... remove for ? |
| src/widgets/previewjob.cpp | ||
|---|---|---|
| 718 ↗ | (On Diff #79991) | Now there are extra spaces on that line. :) |