| meven | |
| davidedmundson | |
| ngraham |
| Plasma |
This option don't work as expected for years on X, and current wayland protocol don't allow to have a proper size for all application (each framework came with this own solution for this option, that mean we will not have same cursor size on different application)
We set default size as 24
BUG: 385920
BUG: 413783
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Those code review are linked to this one:
https://phabricator.kde.org/D28653
https://phabricator.kde.org/D28654
https://phabricator.kde.org/D28655
| kcms/mouse/backends/x11/x11_backend.cpp | ||
|---|---|---|
| 138 | intSize is no longer defines so it fails to build | |
We will need to remove this entry we don't write default value
I will add a migration to be sure nobody have this kind of entry
Other related question.
What happens if we specify the size as being 24, but the icon set doesn't have that?
| kcms/mouse/backends/x11/x11_backend.cpp | ||
|---|---|---|
| 144–145 | No never be empty, not sure what I made there... looks like I reverted something before commiting | |
After locally fixing the compile error, applying this patch as well as all three others, and restarting KWin, I'm unfortunately seeing the bugs marked as fixed still happening: I change the cursor size, click Apply in the KCM, then the cursor size still changes back to the old size when hovering over the desktop, a KWin-drawn titlebar, or the header area of a System Settings KCM.
| kcms/mouse/backends/x11/x11_backend.cpp | ||
|---|---|---|
| 132 | Does ./kcms/mouse/kapplymousetheme.cpp need to be updated as well? | |
I guess is another bug, can you test by restarting the session
The hot apply is still not working on wayland and still broken on X
Yes after restarting the session, the new cursor sized is fully applied everywhere. However 385920 413783 are about applying the cursor size everywhere immediately without having to restart the session, no?
For the wayland one at least I'm sure it's not that because without restarting session nothing happen
For the X one I didn't see anything related to apply on the bug report (but yes the apply bug exist)
But please remove the BUG: keywords for bugs that this patch does not actually fix (and ideally fix them in follow-up patches :) )