KRunner: Show error message for Actions in dbus runner
Needs ReviewPublic

Authored by alex on Apr 5 2020, 8:28 AM.

Details

Reviewers
davidedmundson
broulik
ngraham
Group Reviewers
Plasma
Summary

KRunner now shows error messages for the Actions dbus request.
But they get only shown if the service is not unknown, because the same error message will be shown in the match method.

Test Plan

Make sure that the logging category is enabled and verify that you get debug output when starting KRunner.
Create a runner for example https://cgit.kde.org/scratch/davidedmundson/pythonrunner.git/tree/runner.py and install it.
Make sure that the Actions method is valid and returns actions, they should be displayed without warnings.
Change the return value from a list to 123, a TypeError message should be displayed.
Kill the runner, and type one letter in KRunner. The ServiceUnknown error message gets shown only once (from the match method).

Diff Detail

Repository
R308 KRunner
Branch
dbusrunner_cleanup (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24783
Build 24801: arc lint + arc unit
alex created this revision.Apr 5 2020, 8:28 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 5 2020, 8:28 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
alex requested review of this revision.Apr 5 2020, 8:28 AM
alex updated this revision to Diff 79376.Apr 5 2020, 8:30 AM

Update if condition

alex updated this revision to Diff 79377.Apr 5 2020, 8:31 AM

Update comment

alex added a comment.Apr 23 2020, 1:21 PM

I am also going to try a friendly ping here :-).