Differential D28547

Add .kksrc extension to the file name when global shorcuts scheme is exported
ClosedPublic
Actions

Authored by harogaston on Apr 4 2020, 1:50 AM.

Details

Reviewers
ngraham
mart
Commits
R119:3e8c7dada73e: Add .kksrc extension to the file name when global shorcuts scheme is exported
Summary

The "Global shortcuts" (keys) kcm plugin does not add a corresponding
file extension to the explorted schemes, nevertheless the import
dialog filters files by the ".kksrc" extension causing that some users
are not able to find their exported files. This patch addresses that
situation.

BUG: 406932

Test Plan
  1. Open "Global shortcuts" kcm module
  2. Select File->Export scheme...
  3. Check some random component(s)
  4. Click OK
  5. The save file dialog should have
    1. "All files" selected as filter
    2. "global_shortcuts.kksrc" as suggested file name

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
harogaston created this revision.Apr 4 2020, 1:50 AM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 4 2020, 1:50 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
harogaston requested review of this revision.Apr 4 2020, 1:50 AM
harogaston edited the test plan for this revision. (Show Details)Apr 4 2020, 1:53 AM
harogaston added a reviewer: ngraham.

Sorry @ngraham I couldn't find who to assign as reviewer. I mean not anything that seemed appropriate. If you know who it would be great. Cheers!

harogaston edited the summary of this revision. (Show Details)Apr 4 2020, 2:56 AM
mart accepted this revision.Apr 6 2020, 9:18 AM
This revision is now accepted and ready to land.Apr 6 2020, 9:18 AM
ngraham accepted this revision.Apr 7 2020, 5:20 PM

Very nice!

davidre added a subscriber: davidre.Apr 7 2020, 5:36 PM
davidre added inline comments.
kcms/keys/kglobalshortcutseditor.cpp
54

Why do we need this include?

549

Unrelated change

harogaston updated this revision to Diff 79608.Apr 7 2020, 6:05 PM

Removed unrelated changes

harogaston marked 2 inline comments as done.Apr 7 2020, 6:06 PM
Closed by commit R119:3e8c7dada73e: Add .kksrc extension to the file name when global shorcuts scheme is exported (authored by harogaston, committed by ngraham). · Explain WhyApr 7 2020, 6:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkcms/keys/kglobalshortcutseditor.cpp (34 lines)

Diff 79610

View Options

kcms/keys/kglobalshortcutseditor.cpp

Loading...