Use more UDSEntry::reserve() calls to avoid reallocs on multiple inserts
ClosedPublic
Actions

Authored by kossebau on Apr 3 2020, 2:06 PM.

Details

Reviewers

sitter
meven

Group Reviewers

Frameworks

Commits

R320:7e679b1366fc: Use more UDSEntry::reserve() calls to avoid reallocs on multiple inserts

Diff Detail

Repository

R320 KIO Extras

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

kossebau created this revision.Apr 3 2020, 2:06 PM

Restricted Application added projects: Dolphin, Frameworks. · View Herald TranscriptApr 3 2020, 2:06 PM

Restricted Application added subscribers: kfm-devel, kde-frameworks-devel. · View Herald Transcript

kossebau requested review of this revision.Apr 3 2020, 2:06 PM

Harbormaster completed remote builds in B24675: Diff 79221.Apr 3 2020, 2:06 PM

Seems hard to miss cases like for // +1 for UDS_DISPLAY_NAME but I will trust you did enough review to be confident for all those cases.
A missing one will just cause an allocation anyway which is what this is fixing in the first place, so no arm done basically.

This revision is now accepted and ready to land.Apr 3 2020, 2:28 PM

Closed by commit R320:7e679b1366fc: Use more UDSEntry::reserve() calls to avoid reallocs on multiple inserts (authored by kossebau). · Explain WhyApr 3 2020, 2:43 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			activities/KioActivities.cpp (3 lines)
M			archive/kio_archivebase.cpp (3 lines)
M			man/kio_man.cpp (3 lines)
M			mtp/kio_mtp.cpp (5 lines)
M			network/ioslave/networkslave.cpp (3 lines)
M			recentdocuments/recentdocuments.cpp (1 line)
M			settings/kio_settings.cpp (2 lines)
M			sftp/kio_sftp.cpp (2 lines)
M			smb/dnssddiscoverer.cpp (1 line)
M			smb/wsdiscoverer.cpp (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	79221	a22f9fa		Apr 3 2020, 2:06 PM	★	★
Diff 2	79225	a22f9fa	R320:7e679b1366fc02e6d5d0c82f225ade6d992ca6db	Apr 3 2020, 2:43 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
9d3d58b7c3c6	89441e502993	a22f9fad49e7	Friedrich W. H. Kossebau	Use more UDSEntry::reserve() calls to avoid reallocs on multiple inserts (Show More…)	Apr 3 2020, 2:05 PM