Differential D28366

[krunner] Don't set the position three times in a row
ClosedPublic
Actions

Authored by davidedmundson on Mar 27 2020, 10:23 PM.

Details

Reviewers
apol
Group Reviewers
Plasma
Commits
R120:e2d372d3dfd1: [krunner] Don't set the position three times in a row
Summary

loadConfig calls setFreeFloating. setFreeFloating calls
setLocation

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Plasma. · View Herald TranscriptMar 27 2020, 10:23 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Mar 27 2020, 10:23 PM
davidedmundson updated this revision to Diff 78708.Mar 27 2020, 10:24 PM
davidedmundson retitled this revision from [krunner] Don't set the position twice in a row to [krunner] Don't set the position three times in a row.
davidedmundson edited the summary of this revision. (Show Details)

update

apol accepted this revision.Mar 28 2020, 12:25 AM
This revision is now accepted and ready to land.Mar 28 2020, 12:25 AM
broulik added a subscriber: broulik.Mar 28 2020, 7:51 PM

Can we just nuke this option? I know people on the internetz™ are quite vocal about it but effectively it's just broken and unmaintained

ngraham added a subscriber: ngraham.Mar 28 2020, 8:30 PM
In D28366#636969, @broulik wrote:

Can we just nuke this option? I know people on the internetz™ are quite vocal about it but effectively it's just broken and unmaintained

...That, or make it configurable with a user-facing UI. I agree that hidden features will bit-rot, though.

pereira.alex added a subscriber: pereira.alex.Mar 28 2020, 9:44 PM

I don't want to be *that guy* but this is one of the things I do in every kde desktop I have. User facing configurable UI would be great !

That said, although I love the free floating version, I wouldn't run to xxx desktop if it was removed ! :)

ngraham added a comment.Mar 29 2020, 2:40 AM

Yeah, it's not like the KRunner KCM is currently overflowing with options and it would get lost. :)

Closed by commit R120:e2d372d3dfd1: [krunner] Don't set the position three times in a row (authored by davidedmundson). · Explain WhyApr 3 2020, 11:33 AM
This revision was automatically updated to reflect the committed changes.
broulik added a comment.Apr 6 2020, 7:33 AM

This breaks KRunner's shadow against a top panel:

broulik added a comment.Apr 6 2020, 7:35 AM

Yeah, it's not like the KRunner KCM is currently overflowing with options and it would get lost. :)

You can't move KRunner around, though, either, and the number of results shown is based on screen size and easily overflows the screen when it is free floating.

Revision Contents
Changeset List

PathPackages
Mkrunner/view.cpp (7 lines)

Diff 79206

View Options

krunner/view.cpp

Loading...