pereira.alex (Alexandre Pereira)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Apr 5 2018, 3:53 PM (118 w, 5 d)
Availability
Available

Recent Activity

Apr 25 2020

pereira.alex added a comment to D28057: Fix folderview popup mode list view icon size inheriting icon view icon size.

Re-reviewing this is on my to-do list. Sorry for the delay!

Apr 25 2020, 11:31 PM · Plasma
pereira.alex added a comment to D28057: Fix folderview popup mode list view icon size inheriting icon view icon size.

@ngraham did I do something wrong ? If i did it was not intentional.

Apr 25 2020, 1:48 PM · Plasma

Apr 19 2020

pereira.alex updated the diff for D28057: Fix folderview popup mode list view icon size inheriting icon view icon size.

Trying to fix the bug:

Apr 19 2020, 4:20 PM · Plasma

Apr 10 2020

pereira.alex added a comment to D28057: Fix folderview popup mode list view icon size inheriting icon view icon size.

I would give each view mode its own config value and adjust the code with conditionals; that's not a problem. There are no backwards compatibility concerns here if you do that, except for people currently using list view with gigantic icons, which will become small, fixing the bug. If they complain, we can just tell them that it was a bug and if they want huge list icons again, they'll have to configure them that way deliberately. :)

Alternatively we can give up on allowing the icon size in list view to be configured and just always use a small size.

Apr 10 2020, 1:12 AM · Plasma
pereira.alex added a comment to D28057: Fix folderview popup mode list view icon size inheriting icon view icon size.

I still don't think we need three values in the config file for only two view modes.

Apr 10 2020, 12:37 AM · Plasma

Mar 31 2020

pereira.alex added a comment to D28057: Fix folderview popup mode list view icon size inheriting icon view icon size.

Sorry for the delay, I will resume reviewing this soon.

Mar 31 2020, 6:38 PM · Plasma

Mar 28 2020

pereira.alex added a comment to D28366: [krunner] Don't set the position three times in a row.

I don't want to be *that guy* but this is one of the things I do in every kde desktop I have. User facing configurable UI would be great !

Mar 28 2020, 9:44 PM · Plasma
pereira.alex updated the diff for D28057: Fix folderview popup mode list view icon size inheriting icon view icon size.

Deal with upgrading configuration

Mar 28 2020, 9:07 PM · Plasma
pereira.alex added a comment to D28057: Fix folderview popup mode list view icon size inheriting icon view icon size.

Also forgot to mention:

Mar 28 2020, 8:16 PM · Plasma
pereira.alex updated the diff for D28057: Fix folderview popup mode list view icon size inheriting icon view icon size.

Use single slider and sync values

Mar 28 2020, 8:10 PM · Plasma

Mar 25 2020

pereira.alex added a comment to D28057: Fix folderview popup mode list view icon size inheriting icon view icon size.

Abandoning the existing iconSize config value and adding a new one called gridViewIconSize means that everyone'e existing icon view size will be reset, since nothing will be reading from the iconSize values in the config files anymore. You have two options here:

  1. Don't abandon iconSize for the icon view; keep using it even though its name isn't perfectly descriptive anymore
  2. Create a kconf update script to migrate people's config files so that the existing iconSize values get transformed into gridViewIconSize See https://techbase.kde.org/Development/Tools/Using_kconf_update
Mar 25 2020, 8:17 PM · Plasma

Mar 22 2020

pereira.alex updated the diff for D28057: Fix folderview popup mode list view icon size inheriting icon view icon size.

Fixing bug on changing icon size between list/grid view

Mar 22 2020, 4:34 PM · Plasma

Mar 18 2020

pereira.alex added a comment to D28057: Fix folderview popup mode list view icon size inheriting icon view icon size.

I did the changes above like you said in the patch above.
I didn't applied it yet, because on testing that same patch, I discovered a bug. I reverted the changes ( after saving the work in the above patch ) and tested the current implementation and it also has the bug.

Mar 18 2020, 11:28 AM · Plasma

Mar 17 2020

pereira.alex updated the diff for D28057: Fix folderview popup mode list view icon size inheriting icon view icon size.

Using separate configs for list and icon mode

Mar 17 2020, 9:45 AM · Plasma
pereira.alex added a comment to D28057: Fix folderview popup mode list view icon size inheriting icon view icon size.

Thanks!

Now we have a new problem though: the default icon size for list view is synchronized with the default icon size for icon view, so it's now gigantic by default:

We need for the default value itself to be different for icon vs list view, while allowing each one to be independent. Probably the cleanest way to do this is to define a new value in the config file for the default list view icon size (could be called something like listViewIconSize) and then change makeIconSize() (good thing you kept it, lol) to return return FolderTools.iconSizeFromTheme(plasmoid.configuration.listViewIconSize) when it's in list view.

Does that make sense?

Mar 17 2020, 8:56 AM · Plasma
pereira.alex added a comment to D11977: Change the default animationTime of 350 to 250, like most other effects.
In D11977#257168, @mart wrote:

250 is fine, and yeah, on x11 risks more to stutter.
what would be needed is perhaps having a single, kdeglobals level setting for animation duration.

Oh look, we have that now. :)

@pereira.alex, maybe you would be interested in porting this effect (and perhaps others too) to read the duration from that setting?

Mar 17 2020, 8:53 AM · KWin
pereira.alex updated the diff for D28057: Fix folderview popup mode list view icon size inheriting icon view icon size.

Remove visible: true since its default

Mar 17 2020, 12:05 AM · Plasma

Mar 16 2020

pereira.alex added a comment to D28053: Make the animation slider more granular.

thank you all for the positive feedback :)

Mar 16 2020, 11:51 PM · Plasma
pereira.alex updated the diff for D28057: Fix folderview popup mode list view icon size inheriting icon view icon size.

Removed commented code

Mar 16 2020, 11:41 PM · Plasma
pereira.alex added a comment to D28055: Fix on wayland activating minimized window will move window to current desktop.
In D28055#628705, @zzag wrote:

it will put window to VD1 and VD2.

It seems to me like this bug must be fixed in KWin rather than the task manager.

Mar 16 2020, 11:22 PM · Plasma

Mar 15 2020

pereira.alex requested review of D28057: Fix folderview popup mode list view icon size inheriting icon view icon size.
Mar 15 2020, 2:32 PM · Plasma
pereira.alex removed a reviewer for D28055: Fix on wayland activating minimized window will move window to current desktop: VDG.
Mar 15 2020, 1:46 PM · Plasma
pereira.alex added reviewers for D28055: Fix on wayland activating minimized window will move window to current desktop: Plasma, VDG.
Mar 15 2020, 1:43 PM · Plasma
pereira.alex requested review of D28055: Fix on wayland activating minimized window will move window to current desktop.
Mar 15 2020, 1:43 PM · Plasma
pereira.alex added reviewers for D28053: Make the animation slider more granular: Plasma, VDG.

Trying to add the correct reviewers :)

Mar 15 2020, 12:19 PM · Plasma
pereira.alex added a comment to D28053: Make the animation slider more granular.

More info: as discussed here: https://www.reddit.com/r/kde/comments/fgwcou/tip_animation_speedslider/

Mar 15 2020, 11:52 AM · Plasma
pereira.alex requested review of D28053: Make the animation slider more granular.
Mar 15 2020, 11:47 AM · Plasma

Apr 23 2018

pereira.alex added a comment to D11976: Change/improve default settings of glide effect.

The idea how the glide effect was implemented is to have this angle. The defaults have not been changed since the effect got introduced.

As this is an effect not enabled by default I do not see the need to change any default settings.

Apr 23 2018, 5:15 PM · KWin

Apr 6 2018

pereira.alex added a comment to D11976: Change/improve default settings of glide effect.

As you work through this, can you please also upload videos to understand the changes visually too?

Apr 6 2018, 6:56 AM · KWin
pereira.alex added a comment to D11976: Change/improve default settings of glide effect.
In D11976#240923, @zzag wrote:

Tilt nowadays may be too much wobbly , and being default the user might be put off immediatly. Btw tilt was not one of the original purposes of Glide. At least not when I developed it.

So, it has nothing to do with http://wiki.compiz.org/Plugins/Animation#Glide_1 ?

Apr 6 2018, 12:01 AM · KWin

Apr 5 2018

pereira.alex added a comment to D11977: Change the default animationTime of 350 to 250, like most other effects.
In D11977#240918, @zzag wrote:

Why another patch? Because it's settings related, you could change animation duration in D11976.

Apr 5 2018, 11:56 PM · KWin
pereira.alex added a comment to D11976: Change/improve default settings of glide effect.
In D11976#240917, @zzag wrote:

It was to be similar to scale effect, but scale effect only "appears", doesnt animate closing. Also with the purpose to "appear from below" or "appear from above" to be configurable. I actually never used it as "rotation of windows"!

-1, sorry. (please notice that I'm not a member of KWin so you shouldn't worry what I think ;-)

Having tilt is one of the purposes(or key components) of the glide effect. IIRC Glide 1 from Compiz also has some angle.

Apr 5 2018, 11:53 PM · KWin
pereira.alex added a comment to T7856: Turn on Fade effect.

I made two change requests:
https://phabricator.kde.org/D11976 and
https://phabricator.kde.org/D11977

Apr 5 2018, 11:45 PM · Kubuntu
pereira.alex requested review of D11977: Change the default animationTime of 350 to 250, like most other effects.
Apr 5 2018, 11:43 PM · KWin
pereira.alex added a comment to D11976: Change/improve default settings of glide effect.
In D11976#240900, @zzag wrote:

glide effect to remove the angle and appear from above and disappear to below

I thought that was the point of the glide effect.

With these new params it looks pretty much like scale effect.

Apr 5 2018, 11:21 PM · KWin
pereira.alex requested review of D11976: Change/improve default settings of glide effect.
Apr 5 2018, 11:01 PM · KWin
pereira.alex added a comment to T7856: Turn on Fade effect.

I have been away from development for a long time. It was very diferently in the kde3 era :)

Apr 5 2018, 10:42 PM · Kubuntu
pereira.alex added a comment to T7856: Turn on Fade effect.

As the initial author of the glide effect ( then code was cleaned and improved by the kwin team ), there was something I should have done at the time : Change the defaults !
I never really planned it to be like in the default manner.

Apr 5 2018, 4:12 PM · Kubuntu
pereira.alex added a comment to T7911: Kubuntu should install PowerTOP and TLP and turn them on during installation : Publicity & Testing needed; re-evaluate for 18.10.

I am new here, hope i am not out of order by replying here but using TLP before made my desktop computer freeze randomly from time to time. It was quite a hard to figure out it was TLP's fault because it was quite random ( it seems it was a problem between TLP and ssd disk ).

Apr 5 2018, 4:03 PM · Kubuntu