It compiles and a quick test of auto-replace regex seems to work.
Details
Details
- Reviewers
psn hein mlaurent - Group Reviewers
Konversation - Commits
- R7:f71dd88d5505: [Application] Port QRegExp to QRegularExpression
Diff Detail
Diff Detail
- Repository
- R7 Konversation
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
src/application.cpp | ||
---|---|---|
1151 | The comment said "case insensitive" but the code said "Qt::CaseSensitive", which is it? |
src/application.cpp | ||
---|---|---|
1151 | Looks to be that it should be case sensitive from the git history and it makes sense to me so I think the comment is wrong |
src/application.cpp | ||
---|---|---|
1151 | OK, thanks for the clarification; QRegularExpression matches case-sensitively by default. |