Differential D28299

[Application] Port QRegExp to QRegularExpression
ClosedPublic
Actions

Authored by ahmadsamir on Mar 26 2020, 9:37 AM.

Tags

None

Subscribers

None

Details

Reviewers

psn
hein
mlaurent

Group Reviewers

Commits

R7:f71dd88d5505: [Application] Port QRegExp to QRegularExpression

Test Plan

It compiles and a quick test of auto-replace regex seems to work.

Diff Detail

Repository

R7 Konversation

Branch

l-application (branched from master)

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 24258
Build 24276: arc lint + arc unit

ahmadsamir requested review of this revision.Mar 26 2020, 9:37 AM

ahmadsamir created this revision.

Harbormaster completed remote builds in B24254: Diff 78526.Mar 26 2020, 9:37 AM

ahmadsamir added inline comments.Mar 26 2020, 10:12 AM

src/application.cpp
1151	The comment said "case insensitive" but the code said "Qt::CaseSensitive", which is it?

psn added inline comments.Mar 26 2020, 10:55 AM

src/application.cpp
1151	Looks to be that it should be case sensitive from the git history and it makes sense to me so I think the comment is wrong

Remove redundant comment

Harbormaster completed remote builds in B24258: Diff 78534.Mar 26 2020, 11:06 AM

ahmadsamir added inline comments.Mar 26 2020, 11:07 AM

src/application.cpp
1151	OK, thanks for the clarification; QRegularExpression matches case-sensitively by default.

Ping. :)

psn accepted this revision.Mar 27 2020, 6:34 PM

This revision is now accepted and ready to land.Mar 27 2020, 6:34 PM

Rebase

Harbormaster completed remote builds in B24350: Diff 78696.Mar 27 2020, 6:39 PM

Closed by commit R7:f71dd88d5505: [Application] Port QRegExp to QRegularExpression (authored by ahmadsamir). · Explain WhyMar 27 2020, 6:40 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/application.cpp (64 lines)

Diff 78534

src/application.cpp

Loading...