[Application] Port QRegExp to QRegularExpression
ClosedPublic

Authored by ahmadsamir on Thu, Mar 26, 9:37 AM.

Details

Test Plan

It compiles and a quick test of auto-replace regex seems to work.

Diff Detail

Repository
R7 Konversation
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahmadsamir requested review of this revision.Thu, Mar 26, 9:37 AM
ahmadsamir created this revision.
ahmadsamir added inline comments.Thu, Mar 26, 10:12 AM
src/application.cpp
1151

The comment said "case insensitive" but the code said "Qt::CaseSensitive", which is it?

psn added inline comments.Thu, Mar 26, 10:55 AM
src/application.cpp
1151

Looks to be that it should be case sensitive from the git history and it makes sense to me so I think the comment is wrong

Remove redundant comment

ahmadsamir added inline comments.Thu, Mar 26, 11:07 AM
src/application.cpp
1151

OK, thanks for the clarification; QRegularExpression matches case-sensitively by default.

psn accepted this revision.Fri, Mar 27, 6:34 PM
This revision is now accepted and ready to land.Fri, Mar 27, 6:34 PM
This revision was automatically updated to reflect the committed changes.