As is KWin only had 1 Cursor which was a singleton. This made it impossible for
us to properly implement the tablet (as in drawing tablets) support and show where
we're drawing.
This patch makes it possible to have different Cursors in KWin, it makes all the
current code still follow the mouse but the tablet can still render a cursor.
Details
- Reviewers
cblack davidedmundson - Group Reviewers
KWin - Commits
- R108:6abd23ed0220: Make it possible to have a separate cursor for the tablet
Tests pass, been using it and works as well as before but with beautiful tablet cursors.
Diff Detail
- Repository
- R108 KWin
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 23967 Build 23985: arc lint + arc unit
Works as advertised, and nothing stands out to me as needing improvement in the code, buuut I would probably wait on the review of a more experienced KWin person.
It would probably be better from a UX perspective to render multiple cursors, one per input device, as it's jarring when the visual cursor jumps around switching between input devices. It took me a while to verify that the cursors for my tablet and my mouse were actually moving independently. Not sure that's within the scope of this patch, though.
It would probably be better from a UX perspective to render multiple cursors, one per input device, as it's jarring when the visual cursor jumps around switching between input devices.
Agreed. It needs some additional work on the DrmBackend (or any backend that wants it really) and figured the patch is big enough as is. Would be a nice thing to add later, not that hard to do either I'd say.