Details

Reviewers

cblack
davidedmundson

Group Reviewers

KWin

Commits

R108:6abd23ed0220: Make it possible to have a separate cursor for the tablet

Summary

As is KWin only had 1 Cursor which was a singleton. This made it impossible for
us to properly implement the tablet (as in drawing tablets) support and show where
we're drawing.
This patch makes it possible to have different Cursors in KWin, it makes all the
current code still follow the mouse but the tablet can still render a cursor.

Test Plan

Tests pass, been using it and works as well as before but with beautiful tablet cursors.

Diff Detail

Repository

R108 KWin

Branch

arcpatch-D28155

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 24484
Build 24502: arc lint + arc unit

apol created this revision.Mar 20 2020, 2:14 AM

Restricted Application added a project: KWin. · View Herald TranscriptMar 20 2020, 2:14 AM

Restricted Application added a subscriber: kwin. · View Herald Transcript

apol requested review of this revision.Mar 20 2020, 2:14 AM

Harbormaster completed remote builds in B23967: Diff 78067.Mar 20 2020, 2:14 AM

arc put this part on the previous patch 8-)

Harbormaster completed remote builds in B23968: Diff 78068.Mar 20 2020, 2:50 AM

rebase

Harbormaster completed remote builds in B24141: Diff 78351.Mar 24 2020, 1:16 PM

apol retitled this revision from WIP: Make it possible to have a separate cursor for the tablet to Make it possible to have a separate cursor for the tablet.Mar 24 2020, 2:32 PM

apol edited the test plan for this revision. (Show Details)

Ping?

Works as advertised, and nothing stands out to me as needing improvement in the code, buuut I would probably wait on the review of a more experienced KWin person.

It would probably be better from a UX perspective to render multiple cursors, one per input device, as it's jarring when the visual cursor jumps around switching between input devices. It took me a while to verify that the cursors for my tablet and my mouse were actually moving independently. Not sure that's within the scope of this patch, though.

This revision is now accepted and ready to land.Mar 30 2020, 2:44 PM

Idea seems sensible.

autotests/integration/pointer_input.cpp
172	why is this needed?
cursor.cpp
49	What happens when a cursor is deleted? For the tablet case it's parented to the tool

This revision now requires changes to proceed.Mar 30 2020, 2:46 PM

Just noticed that a cursor renders at 0,0 when exiting the session with this patch.

It would probably be better from a UX perspective to render multiple cursors, one per input device, as it's jarring when the visual cursor jumps around switching between input devices.

Agreed. It needs some additional work on the DrmBackend (or any backend that wants it really) and figured the patch is big enough as is. Would be a nice thing to add later, not that hard to do either I'd say.

Address David's comments

Harbormaster completed remote builds in B24484: Diff 78921.Mar 30 2020, 5:09 PM

davidedmundson accepted this revision.Apr 2 2020, 11:28 AM

This revision is now accepted and ready to land.Apr 2 2020, 11:28 AM

Closed by commit R108:6abd23ed0220: Make it possible to have a separate cursor for the tablet (authored by apol). · Explain WhyApr 2 2020, 11:16 PM

This revision was automatically updated to reflect the committed changes.

This makes KWin crash for me. :(

https://bugs.kde.org/show_bug.cgi?id=419595

			Path	Packages
M			abstract_client.cpp (20 lines)
M			activation.cpp (4 lines)
M			autotests/CMakeLists.txt (3 lines)
M			autotests/integration/activation_test.cpp (2 lines)
M			autotests/integration/activities_test.cpp (2 lines)
M			autotests/integration/decoration_input_test.cpp (10 lines)
M			autotests/integration/desktop_window_x11_test.cpp (2 lines)
M			autotests/integration/dont_crash_aurorae_destroy_deco.cpp (2 lines)
M			autotests/integration/dont_crash_cursor_physical_size_empty.cpp (6 lines)
M			autotests/integration/dont_crash_empty_deco.cpp (2 lines)
M			autotests/integration/dont_crash_no_border.cpp (2 lines)
M			autotests/integration/dont_crash_useractions_menu.cpp (2 lines)
M			autotests/integration/effects/translucency_test.cpp (2 lines)
M			autotests/integration/effects/wobbly_shade_test.cpp (6 lines)
M			autotests/integration/globalshortcuts_test.cpp (2 lines)
M			autotests/integration/input_stacking_order.cpp (2 lines)
M			autotests/integration/internal_window.cpp (6 lines)
M			autotests/integration/kwinbindings_test.cpp (2 lines)
M			autotests/integration/lockscreen.cpp (2 lines)
M			autotests/integration/maximize_test.cpp (2 lines)
M			autotests/integration/modifier_only_shortcut_test.cpp (2 lines)
M			autotests/integration/move_resize_window_test.cpp (36 lines)
M			autotests/integration/no_global_shortcuts_test.cpp (2 lines)
M			autotests/integration/placement_test.cpp (6 lines)
M			autotests/integration/plasma_surface_test.cpp (4 lines)
M			autotests/integration/plasmawindow_test.cpp (2 lines)
M			autotests/integration/platformcursor.cpp (8 lines)
M			autotests/integration/pointer_constraints_test.cpp (50 lines)
M			autotests/integration/pointer_input.cpp (139 lines)
M			autotests/integration/quick_tiling_test.cpp (16 lines)
M			autotests/integration/scene_qpainter_test.cpp (40 lines)
M			autotests/integration/screen_changes_test.cpp (2 lines)
M			autotests/integration/screenedge_client_show_test.cpp (8 lines)
M			autotests/integration/scripting/screenedge_test.cpp (14 lines)
M			autotests/integration/shade_test.cpp (2 lines)
M			autotests/integration/struts_test.cpp (4 lines)
M			autotests/integration/tabbox_test.cpp (2 lines)
M			autotests/integration/touch_input_test.cpp (2 lines)
M			autotests/integration/transient_placement.cpp (2 lines)
M			autotests/integration/window_rules_test.cpp (2 lines)
M			autotests/integration/window_selection_test.cpp (20 lines)
M			autotests/integration/x11_client_test.cpp (72 lines)
M			autotests/integration/xdgshellclient_rules_test.cpp (30 lines)
M			autotests/integration/xdgshellclient_test.cpp (14 lines)
M			autotests/integration/xwayland_input_test.cpp (14 lines)
M			autotests/test_screen_edges.cpp (108 lines)
M			autotests/test_screens.cpp (14 lines)
M			autotests/test_scripted_effectloader.cpp (9 lines)
M			cursor.h (85 lines)
M			cursor.cpp (147 lines)
M			decorations/decoratedclient.cpp (4 lines)
M			effects.cpp (20 lines)
M			events.cpp (8 lines)
M			input.cpp (39 lines)
M			placement.cpp (12 lines)
M			platform.h (6 lines)
M			platform.cpp (33 lines)
M			plugins/platforms/drm/drm_backend.h (3 lines)
M			plugins/platforms/drm/drm_backend.cpp (23 lines)
M			plugins/platforms/drm/drm_output.h (3 lines)
M			plugins/platforms/drm/drm_output.cpp (9 lines)
M			plugins/platforms/wayland/wayland_backend.cpp (16 lines)
M			plugins/platforms/x11/standalone/edge.cpp (4 lines)
M			plugins/platforms/x11/standalone/effects_x11.cpp (2 lines)
M			plugins/platforms/x11/standalone/windowselector.cpp (10 lines)
M			plugins/platforms/x11/windowed/x11windowed_backend.cpp (9 lines)
M			plugins/qpa/platformcursor.cpp (4 lines)
M			plugins/scenes/opengl/scene_opengl.cpp (12 lines)
M			plugins/scenes/qpainter/scene_qpainter.cpp (10 lines)
M			pointer_input.h (88 lines)
M			pointer_input.cpp (234 lines)
M			screenedge.cpp (4 lines)
M			screens.cpp (2 lines)
M			useractions.cpp (16 lines)
M			wayland_cursor_theme.cpp (4 lines)
M			workspace.cpp (2 lines)
M			x11client.cpp (12 lines)
M			xdgshellclient.cpp (10 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	78067	e0052ce		Mar 20 2020, 2:14 AM	★	★
Diff 2	78068	4396912	arc put this part on the previous patch 8-)	Mar 20 2020, 2:50 AM	★	★
Diff 3	78351	754b90c	rebase	Mar 24 2020, 1:15 PM	★	★
Diff 4	78921	9755ef2	Address David's comments	Mar 30 2020, 5:09 PM	★	★
Diff 5	79178	08a21ae	R108:6abd23ed0220b14a4a05fa280869ba3c953565e3	Apr 2 2020, 11:16 PM	★	★

Make it possible to have a separate cursor for the tabletClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 78921

abstract_client.cpp

activation.cpp

autotests/CMakeLists.txt

autotests/integration/activation_test.cpp

autotests/integration/activities_test.cpp

autotests/integration/decoration_input_test.cpp

autotests/integration/desktop_window_x11_test.cpp

autotests/integration/dont_crash_aurorae_destroy_deco.cpp

autotests/integration/dont_crash_cursor_physical_size_empty.cpp

autotests/integration/dont_crash_empty_deco.cpp

autotests/integration/dont_crash_no_border.cpp

autotests/integration/dont_crash_useractions_menu.cpp

autotests/integration/effects/translucency_test.cpp

autotests/integration/effects/wobbly_shade_test.cpp

autotests/integration/globalshortcuts_test.cpp

autotests/integration/input_stacking_order.cpp

autotests/integration/internal_window.cpp

autotests/integration/kwinbindings_test.cpp

autotests/integration/lockscreen.cpp

autotests/integration/maximize_test.cpp

autotests/integration/modifier_only_shortcut_test.cpp

autotests/integration/move_resize_window_test.cpp

autotests/integration/no_global_shortcuts_test.cpp

autotests/integration/placement_test.cpp

autotests/integration/plasma_surface_test.cpp

autotests/integration/plasmawindow_test.cpp

autotests/integration/platformcursor.cpp

autotests/integration/pointer_constraints_test.cpp

autotests/integration/pointer_input.cpp

autotests/integration/quick_tiling_test.cpp

autotests/integration/scene_qpainter_test.cpp

autotests/integration/screen_changes_test.cpp

autotests/integration/screenedge_client_show_test.cpp

autotests/integration/scripting/screenedge_test.cpp

autotests/integration/shade_test.cpp

autotests/integration/struts_test.cpp

autotests/integration/tabbox_test.cpp

autotests/integration/touch_input_test.cpp

autotests/integration/transient_placement.cpp

autotests/integration/window_rules_test.cpp

autotests/integration/window_selection_test.cpp

autotests/integration/x11_client_test.cpp

autotests/integration/xdgshellclient_rules_test.cpp

autotests/integration/xdgshellclient_test.cpp

autotests/integration/xwayland_input_test.cpp

autotests/test_screen_edges.cpp

autotests/test_screens.cpp

autotests/test_scripted_effectloader.cpp

cursor.h

cursor.cpp

decorations/decoratedclient.cpp

effects.cpp

events.cpp

input.cpp

placement.cpp

platform.h

platform.cpp

plugins/platforms/drm/drm_backend.h

plugins/platforms/drm/drm_backend.cpp

plugins/platforms/drm/drm_output.h

plugins/platforms/drm/drm_output.cpp

plugins/platforms/wayland/wayland_backend.cpp

plugins/platforms/x11/standalone/edge.cpp

plugins/platforms/x11/standalone/effects_x11.cpp

plugins/platforms/x11/standalone/windowselector.cpp

plugins/platforms/x11/windowed/x11windowed_backend.cpp

plugins/qpa/platformcursor.cpp

plugins/scenes/opengl/scene_opengl.cpp

plugins/scenes/qpainter/scene_qpainter.cpp

pointer_input.h

pointer_input.cpp

screenedge.cpp

screens.cpp

useractions.cpp

wayland_cursor_theme.cpp

Make it possible to have a separate cursor for the tablet
ClosedPublic
Actions

Revision Contents
Changeset List