Differential D28130

Introduce api for passive notifications
ClosedPublic
Actions

Authored by mart on Mar 18 2020, 4:37 PM.

Details

Reviewers
broulik
Commits
R296:cebaeb4daf59: Introduce api for passive notifications
Summary

showPassiveNotification which mirrors
ApplicationWindow.showPassiveNotification
some kcms need to show a tiny non interrupting message for which neither
a dialog nor an InlineMessage are adapt.
see D28131

Test Plan

Diff Detail

Repository
R296 KDeclarative
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Mar 18 2020, 4:37 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 18 2020, 4:37 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mart requested review of this revision.Mar 18 2020, 4:37 PM
mart edited the summary of this revision. (Show Details)Mar 18 2020, 4:40 PM
mart edited the test plan for this revision. (Show Details)
mart mentioned this in D28103: Support multiple stacked Passive Notifications.
broulik added a subscriber: broulik.Mar 19 2020, 8:42 AM
broulik added inline comments.
src/quickaddons/configmodule.h
507

const QVariant &

davidre added a subscriber: davidre.Mar 19 2020, 8:50 AM

I wonder if it's for the use case wehere an InlineMessage doesn't work does it need to contain actions?

mart added a comment.Mar 19 2020, 9:06 AM
In D28130#630325, @davidre wrote:

I wonder if it's for the use case wehere an InlineMessage doesn't work does it need to contain actions?

doesn't really *need* it, but matches the existing api already existing in ApplicationWindow

mart added a comment.Mar 19 2020, 10:00 AM
In D28130#630325, @davidre wrote:

I wonder if it's for the use case wehere an InlineMessage doesn't work does it need to contain actions?

doesn't really *need* it, but matches the existing api already existing in ApplicationWindow which is better to not have inconsitencies

mart updated this revision to Diff 77982.Mar 19 2020, 10:01 AM
  • const QVariant &
mart updated this revision to Diff 77983.Mar 19 2020, 10:05 AM
  • const QVariant &
broulik accepted this revision.Mar 19 2020, 10:10 AM
This revision is now accepted and ready to land.Mar 19 2020, 10:10 AM
Closed by commit R296:cebaeb4daf59: Introduce api for passive notifications (authored by mart). · Explain WhyMar 19 2020, 10:22 AM
This revision was automatically updated to reflect the committed changes.
mart mentioned this in R295:3fe22e067a73: listen to passiveNotificationRequested.

Revision Contents
Changeset List

Diff 77987

View Options

src/quickaddons/configmodule.h

Loading...
View Options

src/quickaddons/configmodule.cpp

Loading...