Introduce api for passive notifications
ClosedPublic

Authored by mart on Wed, Mar 18, 4:37 PM.

Details

Summary

showPassiveNotification which mirrors
ApplicationWindow.showPassiveNotification
some kcms need to show a tiny non interrupting message for which neither
a dialog nor an InlineMessage are adapt.
see D28131

Test Plan

Diff Detail

Repository
R296 KDeclarative
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Wed, Mar 18, 4:37 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptWed, Mar 18, 4:37 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mart requested review of this revision.Wed, Mar 18, 4:37 PM
mart edited the summary of this revision. (Show Details)Wed, Mar 18, 4:40 PM
mart edited the test plan for this revision. (Show Details)
broulik added inline comments.
src/quickaddons/configmodule.h
507

const QVariant &

I wonder if it's for the use case wehere an InlineMessage doesn't work does it need to contain actions?

mart added a comment.Thu, Mar 19, 9:06 AM

I wonder if it's for the use case wehere an InlineMessage doesn't work does it need to contain actions?

doesn't really *need* it, but matches the existing api already existing in ApplicationWindow

mart added a comment.Thu, Mar 19, 10:00 AM

I wonder if it's for the use case wehere an InlineMessage doesn't work does it need to contain actions?

doesn't really *need* it, but matches the existing api already existing in ApplicationWindow which is better to not have inconsitencies

mart updated this revision to Diff 77982.Thu, Mar 19, 10:01 AM
  • const QVariant &
mart updated this revision to Diff 77983.Thu, Mar 19, 10:05 AM
  • const QVariant &
broulik accepted this revision.Thu, Mar 19, 10:10 AM
This revision is now accepted and ready to land.Thu, Mar 19, 10:10 AM
This revision was automatically updated to reflect the committed changes.