Another huge one guys, sorry.
SVN Log missing in current SVN pluging but this is one of the most important features (and one of the most required in my everyday needs).
I am ready for comments and updates.

SVN log is parsed via 'svn log --verbose --xml' because it contatins the most complete log information.

Dialog looks and behaves similar to a TortoiseSVN one.

Don't make dialogs to looks like 3-th party software, we have log in git, you can make like that, also it pretty simple.

Thanks in advance for fixing these typos and removing the executable bit from the source file permissions.

In D28102#629437, @anthonyfieroni wrote:

Dialog looks and behaves similar to a TortoiseSVN one.

Don't make dialogs to looks like 3-th party software, we have log in git, you can make like that, also it pretty simple.

Thanks for response.
First of all, being similar to something good is not that bad. But again this is only "looks and behaves similar", this is not a "copy-paste".
Second of all, this dialog contains only features i (and in my opinion most users) use daily. This is also a 'git log' problem: its not enough for me and pushes me to use several tools.

Anyway i'm ready for updates.

In D28102#629533, @elvisangelaccio wrote:

From a quick look it seems there is a lot of refactored code, this could be done separately in another commit, right?

This is mostly a new code. For better understanding i think we can separate it:

1. commit with SvnCommands: all new additions.
2. commit with FileViewSvnPlugin: all new funcionality (except log dialog call).
3. add SvnLogDialog.

It there a way we can introduce this to the upcoming 20.04LTS? How much time do we have?

That said, the UI looks good to me. I feel it's a bit slow though, maybe 100 is too much as log length? I suppose parsing the XML is not cheap.

For my remote repo with "time svn log - l 100..." it takes around 2.3sec for xml and 2.0sec without xml (this average for a five measures).
Parsing xml itself takes around 0.1sec in the debug build.
As you can see svn log itself is slow. Both 2.3sec and 1.8sec is unacceptable. We need to think about caching log entries (like TortoiseSVN does), this is a big deal and maybe we should do it later. From all of the above it follows I suggest to use this code with possible future upgrades.
What do you say about 50 for log length? It tooks around 0.3sec xml and 0.25sec without xml for me.

If you really would like this feature in 20.04, we have until 23.59 of tomorrow (March 19).

I'd say let's not split it then, it will be quicker to review (I'll do it now).

Ah right, you probably don't (time to fix that!).

I'll push it for you since the freeze is very close.