Braces around if blocks.
Details
Details
- Reviewers
dfaure apol - Group Reviewers
Frameworks - Commits
- R241:66837e4c049d: GIT_SILENT clang-format kpasswdserver.*
make && ctest
Diff Detail
Diff Detail
- Repository
- R241 KIO
- Branch
- l-kpasswdserver-clang-format (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 23808 Build 23826: arc lint + arc unit
| src/kpasswdserver/kpasswdserver.cpp | ||
|---|---|---|
| 249 | This didn't use to be called when m_walletDisabled is true. Make it a lambda if you want to simplify the if() condition while still preserving evaluation order? Or better: let's not change code in a "reformatting" commit... It's too dangerous. I could have missed this. Reviewing reformatting from a tool and reviewing changes made by a human are two different kinds of reviews :-) | |
| 309 | same | |
| 748 | same | |
Comment Actions
clang-format only, less prone to errors, as the level of stupidity of the tool is locked at the compile time of the tool (unlike manual changes)