KRun bothers with a WId in many places just to end up calling
KStartupInfoData::setLaunchedBy... and nobody uses that value anywhere.
Time to deprecate this and simplify KRun (which I'm rewriting).
Details
Details
Builds. Warns when used in KIO.
Diff Detail
Diff Detail
- Repository
- R278 KWindowSystem
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 23641 Build 23659: arc lint + arc unit
Comment Actions
Do you know why LAUNCHED_BY was added? The spec [1] has no a single word about its potential use cases.
[1] https://specifications.freedesktop.org/startup-notification-spec/startup-notification-latest.txt
Comment Actions
I don't 100% agree that "it doesn't seem used".
It's used in KStartupInfoData::Private::to_text() which affects what gets written out over the wire to everyone else.
At which point we can't just look internally at what we happen to use in KDE, we need to ask if anyone else in the world uses that property.
From what I can tell, kwin doesn't read it back in any form, the spec does explicitly say it's optional, and not even GTK sets it...so it's probably safe.
Comment Actions
Maybe it would be worth to send an email to wm-spec-list proposing to deprecate LAUNCHED_BY, but on the other hand fixing X11 stuff in any way is like beating a dead horse.