Differential D27996

Fix undefined check in global drawer menu mode
ClosedPublic
Actions

Authored by nicolasfella on Mar 11 2020, 8:18 PM.

Details

Reviewers
mart
ngraham
Group Reviewers
Kirigami
Commits
R169:4d84d3f1d93f: Fix undefined check in global drawer menu mode
Summary

Kamoso uses Overlaydrawer instead of GlobalDrawer, which has no isMenu property

BUG: 417956

Test Plan

Kamoso doesn't have an empty second hamburger button any more

Diff Detail

Repository
R169 Kirigami
Branch
fixkamoso
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23595
Build 23613: arc lint + arc unit
nicolasfella created this revision.Mar 11 2020, 8:18 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptMar 11 2020, 8:18 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
nicolasfella requested review of this revision.Mar 11 2020, 8:18 PM
ngraham accepted this revision.Mar 11 2020, 8:33 PM
ngraham added a subscriber: ngraham.

Hah I was just investigating this the other day but couldn't find it. This makes sense.

This revision is now accepted and ready to land.Mar 11 2020, 8:33 PM
apol added a subscriber: apol.Mar 11 2020, 9:49 PM
apol added inline comments.
src/controls/private/globaltoolbar/PageRowGlobalToolBarUI.qml
49

Wouldn't it be easier to do:

visible: !Kirigami.Settings.isMobile && applicationWindow().globalDrawer && applicationWindow().globalDrawer.isMenu

?

Otherwise we better check for the property with "isMenu" in applicationWindow().globalDrawer

nicolasfella marked an inline comment as done.Mar 11 2020, 9:55 PM
nicolasfella added inline comments.
src/controls/private/globaltoolbar/PageRowGlobalToolBarUI.qml
49

The former gives Unable to assign [undefined] to bool

nicolasfella marked an inline comment as done.Mar 11 2020, 9:55 PM
Closed by commit R169:4d84d3f1d93f: Fix undefined check in global drawer menu mode (authored by nicolasfella). · Explain WhyMar 14 2020, 7:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 77465

View Options

src/controls/private/globaltoolbar/PageRowGlobalToolBarUI.qml

Loading...