KParts: add unittest for PartLoader, required shuffling things around
ClosedPublic
Actions

Authored by dfaure on Mar 10 2020, 10:33 AM.

Details

Reviewers

aacid
nicolasfella
kossebau

Maniphest Tasks

T12173: KService: provide solution to migrate away from KServiceTypeTrader/KMimeTypeTrader for loading plugins and parts

Commits

R306:d0665603ea33: KParts: add unittest for PartLoader, required shuffling things around

Summary

The notepad part was part of the interactive test programs, move it to
autotests. Generate JSON for it. Put XMLGUI file in qrc.
Adapt interactive tests to find the notepadpart the new way.

Test Plan

make && ctest

Diff Detail

Repository

R306 KParts

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

dfaure requested review of this revision.Mar 10 2020, 10:33 AM

dfaure created this revision.

Harbormaster completed remote builds in B23507: Diff 77341.Mar 10 2020, 10:33 AM

aacid accepted this revision.Mar 13 2020, 8:36 PM

This revision is now accepted and ready to land.Mar 13 2020, 8:36 PM

Closed by commit R306:d0665603ea33: KParts: add unittest for PartLoader, required shuffling things around (authored by dfaure). · Explain WhyMar 21 2020, 10:00 AM

This revision was automatically updated to reflect the committed changes.

Restricted Application added a project: Frameworks. · View Herald TranscriptMar 21 2020, 10:00 AM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

Revision Contents
Changeset List

		Path
M		autotests/CMakeLists.txt (14 lines)
V		{autotests ← tests}/notepad.h (3 lines)
V		{autotests ← tests}/notepad.cpp (9 lines)
A	M	autotests/notepad.qrc (7 lines)
V		{autotests ← tests}/notepadpart.rc
A	M	autotests/partloadertest.cpp (109 lines)
M		src/partloader.h (5 lines)
M		tests/CMakeLists.txt (8 lines)
M		tests/normalktm.cpp (22 lines)
V		{tests → autotests}/notepad.h
V		{tests → autotests}/notepad.cpp
V		{tests → autotests}/notepadpart.rc
M		tests/partviewer.cpp (6 lines)
M		tests/plugin_spellcheck.cpp (4 lines)
M		tests/testmainwindow.cpp (23 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	77341	49d2c36		Mar 10 2020, 10:33 AM	★	★
Diff 2	78145	b617fc0	R306:d0665603ea333337ee6c2da4981883ad77097264	Mar 21 2020, 9:59 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
3da59510d368	c2e4931bae2e	49d2c369c8ca	David Faure	KParts: add unittest for PartLoader, required shuffling things around (Show More…)	Mar 9 2020, 12:48 AM