Add twin commands for gj and gk for usage with standard
arrow keys.
BUG: 418486
FIXED-IN: 5.69
cullmann |
Kate | |
Frameworks |
Add twin commands for gj and gk for usage with standard
arrow keys.
BUG: 418486
FIXED-IN: 5.69
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
I like the patch, but please add a unit test before we commit this. See https://github.com/KDE/ktexteditor/tree/master/autotests/src/vimode
Could you add one? :)
I am not sure where I should add it. Is it supposed to be a new pair of bug418486 .h/.cpp files? Or should the test reside inside keys.cpp in big intimidating 500 line wide MappingTest function?
I added a unit test, but I do not know why it is failing. Actually I do not know if I've added it correctly at all. Help is very necsasary.
I will try to take a look as soon as I have time, if nobody else is faster.
Just to confirm: Your newly added test case doesn't pass or some other test case randomly fails?
I think, one issue is, that <down> and <up> don't work that way in the test framework.
I reformulated the test with \down and \up and moved the asserts to verifies.
This works for me, will push this, please take a look if that is ok for you, too.
And btw., thanks a lot for taking care!
The vimode for sure has more need for love, if you have time ;=)