make && ctest
klipper still seems to work
Details
- Reviewers
davidedmundson apol broulik - Group Reviewers
Plasma - Commits
- R120:bcfd7f28370d: [Kilpper] Port QRegExp to QRegularExpression
Diff Detail
- Repository
- R120 Plasma Workspace
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
klipper/urlgrabber.h | ||
---|---|---|
185–186 | Why did you change how it works right here? |
klipper/urlgrabber.h | ||
---|---|---|
185–186 | I find it confusing to call the pattern "regExp" and the QRegExp object "m_myRegExp". |
klipper/urlgrabber.h | ||
---|---|---|
185–186 | Then call it m_regularExpression? |
klipper/urlgrabber.h | ||
---|---|---|
185–186 | Another point (which I forgot since it has been some time since I last looked at this patch), QRegExp stores the match info in itself, whereas QRegularExpression stores the match info in a QRegularExpressionMatch object (returned from calling QRegularExpression::match()), so if I use a m_regularExpression I'll have to add a getter for it, so that it can be called from URLGrabber::matchingActions(). |
klipper/urlgrabber.h | ||
---|---|---|
185–186 | Then you want to store a match? |
klipper/urlgrabber.h | ||
---|---|---|
185–186 | The code stores the QRegularExpression::capturedTexts(), m_regexCapturedTexts, which is eventually what ClipCommandProcess uses. |
klipper/urlgrabber.h | ||
---|---|---|
185–186 | I think it's a silly way to do the port but okay, probably works and we get to move on. |
klipper/urlgrabber.h | ||
---|---|---|
185–186 | What is silly about it? The original code in ClipCommandProcess used: |