Differential D27855

[Debug] Improve readability of positioninfo debug format
ClosedPublic
Actions

Authored by bruns on Mar 5 2020, 12:32 AM.

Details

Reviewers
ngraham
Group Reviewers
Baloo
Commits
R293:d3d5cda0e462: [Debug] Improve readability of positioninfo debug format
Summary

The docId in hex is shorter and can be better compared with the
serialized data. Also remove extra whitespace.

No functional changes.

Diff Detail

Repository
R293 Baloo
Branch
submit
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23281
Build 23299: arc lint + arc unit
bruns created this revision.Mar 5 2020, 12:32 AM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptMar 5 2020, 12:32 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Mar 5 2020, 12:32 AM
ngraham accepted this revision.Mar 16 2020, 3:07 AM
This revision is now accepted and ready to land.Mar 16 2020, 3:07 AM
Closed by commit R293:d3d5cda0e462: [Debug] Improve readability of positioninfo debug format (authored by bruns). · Explain WhyMar 16 2020, 4:26 PM
This revision was automatically updated to reflect the committed changes.
bcooksley added a subscriber: bcooksley.Mar 17 2020, 8:13 AM

One of the changes in this string of 4 revisions has unfortunately broken the build of Baloo on the CI system.
Please see https://build.kde.org/view/Failing/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.13/90/console

kossebau added a subscriber: kossebau.Mar 17 2020, 4:50 PM

For Qt <5.14 Qt::hex needs to be instead unnamespaced hex, same with Qt::dec -> dec.
Fixed with 28a534ccee9ffa22b2abb7188ab8abb98a099f99

bruns added a comment.Mar 17 2020, 8:58 PM
In D27855#629330, @kossebau wrote:

For Qt <5.14 Qt::hex needs to be instead unnamespaced hex, same with Qt::dec -> dec.
Fixed with 28a534ccee9ffa22b2abb7188ab8abb98a099f99

Thx

Revision Contents
Changeset List

PathPackages
Msrc/engine/positioninfo.h (4 lines)

Diff 76983

View Options

src/engine/positioninfo.h

Loading...