Differential D27828

[server] Introduce SurfaceInterface::boundingRect()
ClosedPublic
Actions

Authored by zzag on Mar 4 2020, 11:03 AM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R127:deb476e47d47: [server] Introduce SurfaceInterface::boundingRect()
Summary

The new method provides a convenient way for determining the rectangle
that bounds the given surface and all of its sub-surfaces. This can be
very handy when determining the effective window geometry.

Diff Detail

Repository
R127 KWayland
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Mar 4 2020, 11:03 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 4 2020, 11:03 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
zzag requested review of this revision.Mar 4 2020, 11:03 AM
zzag updated this revision to Diff 76922.Mar 4 2020, 11:06 AM

Add missing @since

apol added a subscriber: apol.Mar 4 2020, 11:46 AM

Maybe producing the patch that is meant to consume this will help see what's the use for this patch.

zzag mentioned this in D27831: Use SurfaceInterface::boundingRect().Mar 4 2020, 12:14 PM
In D27828#621821, @apol wrote:

Maybe producing the patch that is meant to consume this will help see what's the use for this patch.

D27831

davidedmundson accepted this revision.Mar 4 2020, 12:17 PM
This revision is now accepted and ready to land.Mar 4 2020, 12:17 PM
zzag added a comment.Mar 4 2020, 12:39 PM

I'll merge this patch after 5.68 is tagged.

Closed by commit R127:deb476e47d47: [server] Introduce SurfaceInterface::boundingRect() (authored by zzag). · Explain WhyMar 18 2020, 2:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 77918

View Options

src/server/surface_interface.h

Loading...
View Options

src/server/surface_interface.cpp

Loading...