Details
- Reviewers
elvisangelaccio ngraham - Group Reviewers
Dolphin
Diff Detail
- Repository
- R318 Dolphin
- Lint
Lint Skipped - Unit
Unit Tests Skipped
"update KParts' ReadOnlyPart::localFilePath in DolphinPart::openUrl()"
instead of reverting by:
"don't use KParts::ReadOnlyPart::localFilePath() in DolphinPart"
src/dolphinpart.cpp | ||
---|---|---|
322 | Have you tried to use KParts::ReadOnlyPart::openUrl() instead? (as described here: https://bugs.kde.org/show_bug.cgi?id=416989#c0) |
src/dolphinpart.cpp | ||
---|---|---|
322 | @pdabrowski Ping? |
src/dolphinpart.cpp | ||
---|---|---|
322 | Yes, KParts::ReadOnlyPart::openUrl() seems to work fine here. |
src/dolphinpart.cpp | ||
---|---|---|
322 | No, it doesn't work for remote addresses (tested: fish://localhost/). } else { d->openRemoteFile(); return true; } |
src/dolphinpart.cpp | ||
---|---|---|
322 | Thanks for the test. I merged the invent patch, can you abandon this one? |