Differential D27662

Rewrite nextcloud plugin
ClosedPublic
Actions

Authored by nicolasfella on Feb 25 2020, 9:09 PM.

Details

Reviewers
apol
bshah
Group Reviewers
Frameworks
Commits
R495:bea001a564b1: Rewrite nextcloud plugin
Summary

Let CopyJob and the webdav KIO slave do the hard work. Run the GetCredentialsJob async. Use generic dav-storage service type instead of nextcloud-upload (introduced in D21738).

Test Plan

Shared one or multiple files to my nextcloud

Diff Detail

Repository
R495 Purpose Library
Branch
nextcloud
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22937
Build 22955: arc lint + arc unit
nicolasfella created this revision.Feb 25 2020, 9:09 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 25 2020, 9:09 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.Feb 25 2020, 9:09 PM
nicolasfella updated this revision to Diff 76421.Feb 25 2020, 9:10 PM
  • Remove debug
apol accepted this revision.Feb 25 2020, 11:28 PM
This revision is now accepted and ready to land.Feb 25 2020, 11:28 PM
Closed by commit R495:bea001a564b1: Rewrite nextcloud plugin (authored by nicolasfella). · Explain WhyMar 2 2020, 2:10 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 2 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Diff 76421

View Options

src/plugins/nextcloud/nextcloudjob.cpp

Loading...