Add plugin for nextcloud-login
ClosedPublic

Authored by nicolasfella on Jun 10 2019, 9:34 PM.

Details

Test Plan
  1. Apply this patch and build the project.
  2. Build plasma-settings project to test the plugin.
  3. Open Accounts item. Tap Add Account button.
  4. Select nexcloud from options for nextcloud-login.

Diff Detail

Repository
R156 KAccounts Providers
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rpatwal requested review of this revision.Jun 10 2019, 9:34 PM
rpatwal created this revision.
nicolasfella added inline comments.
plugins/nextcloud-ui/package/metadata.desktop
4

Remove the translations, they are handled automagically

nicolasfella added inline comments.Jun 10 2019, 10:38 PM
plugins/nextcloud-ui/nextcloud.h
44

use override instead of Q_DECL_OVERRIDE

bshah added inline comments.Jun 12 2019, 7:44 AM
plugins/nextcloud-ui/CMakeLists.txt
2

Don't add project here. remove.

4

Coding style in whole cmake file is weird, no space before opening bracket.

plugins/nextcloud-ui/qmlhelper.cpp
76

Remove or replace with the qCDebug.

94

remove qDebugs

116

Fix coding style in all functions.

128

Please document the login flow or link to nextcloud docs.

166

Coding style: indent.

169

Remove.

284

remove

providers/nextcloud.provider.in
7

Use Nextcloud term consistently as upstream uses.

rpatwal updated this revision to Diff 59690.Jun 12 2019, 9:28 PM
  • Fix coding style
rpatwal updated this revision to Diff 60667.Jun 25 2019, 7:10 PM
rpatwal marked 12 inline comments as done.Jul 17 2019, 6:41 PM
  • Correct nextcloud writing
  • Add service file so it shows up in the services list
  • Fix metadata name and remove translations
  • Random cleanup
  • Add setting for Akonadi resource
  • Disable Akonadi support
  • Correctly spell Nextcloud
  • Add storage service
  • Update settings
  • prepend slash to path
  • Add sink resourceId setting
nicolasfella commandeered this revision.Feb 28 2020, 2:25 PM
nicolasfella added a reviewer: rpatwal.
  • Correct nextcloud writing
  • Add service file so it shows up in the services list
  • Fix metadata name and remove translations
  • Random cleanup
  • Add setting for Akonadi resource
  • Disable Akonadi support
  • Correctly spell Nextcloud
  • Add storage service
  • Update settings
  • prepend slash to path
  • Add sink resourceId setting
  • Comment out akonadi setting
bshah accepted this revision.Mar 2 2020, 11:04 AM

Let's merge this in!

This revision is now accepted and ready to land.Mar 2 2020, 11:04 AM
This revision was automatically updated to reflect the committed changes.