Differential D27645

[KCM]Align volume controls row
ClosedPublic
Actions

Authored by gvgeo on Feb 25 2020, 11:12 AM.

Details

Reviewers
drosca
ngraham
Group Reviewers
Plasma
VDG
Commits
R115:ca15ec82c121: [KCM]Align volume controls row
Summary

Align mute button volume slider.

Slider has 2 pixel offset, caused from wrong slider height.

Test Plan

Before:

After:

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Branch
scaleM (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22893
Build 22911: arc lint + arc unit
gvgeo created this revision.Feb 25 2020, 11:12 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 25 2020, 11:12 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gvgeo requested review of this revision.Feb 25 2020, 11:12 AM
gvgeo edited the test plan for this revision. (Show Details)Feb 25 2020, 11:24 AM
broulik added a subscriber: broulik.Feb 25 2020, 11:29 AM
broulik added inline comments.
src/kcm/package/contents/ui/VolumeSlider.qml
43

Eww. Can we fix the slider instead?

gvgeo edited the test plan for this revision. (Show Details)Feb 25 2020, 11:31 AM
gvgeo added inline comments.Feb 25 2020, 11:34 AM
src/kcm/package/contents/ui/VolumeSlider.qml
43

I tried to change qqc2-desktop-style but didn't had any effect.
Wonder If I did something wrong,

gvgeo added a comment.Feb 27 2020, 6:25 AM

Should I remove the slider workaround? And leave it with 2 pixel offset?

gvgeo updated this revision to Diff 76519.Feb 27 2020, 7:57 AM

Removed workaround.

(It would be nice to mention breeze theme.)

gvgeo edited the summary of this revision. (Show Details)Feb 27 2020, 10:38 AM
gvgeo edited the test plan for this revision. (Show Details)
gvgeo edited the summary of this revision. (Show Details)Feb 27 2020, 12:31 PM
gvgeo edited the test plan for this revision. (Show Details)
gvgeo added a comment.EditedFeb 29 2020, 8:12 AM

In my opinion this is better even without the workaround.
Only when scale is 100% for devices, look worse (first photo in before-after).

ngraham added a comment.Mar 3 2020, 6:17 PM

Needs a rebase

gvgeo updated this revision to Diff 76873.Mar 3 2020, 6:40 PM

rebase

gvgeo updated this revision to Diff 76874.Mar 3 2020, 6:42 PM

Math round.

gvgeo updated this revision to Diff 76884.Mar 3 2020, 9:30 PM

Fix rebase.

ngraham accepted this revision.Mar 3 2020, 9:36 PM
This revision is now accepted and ready to land.Mar 3 2020, 9:36 PM
Closed by commit R115:ca15ec82c121: [KCM]Align volume controls row (authored by gvgeo). · Explain WhyMar 4 2020, 9:00 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 76353

View Options

src/kcm/package/contents/ui/DeviceListItem.qml

Loading...
View Options

src/kcm/package/contents/ui/StreamListItem.qml

Loading...
View Options

src/kcm/package/contents/ui/VolumeSlider.qml

Loading...