Differential D27550

Support Qt 5.14 on Android
ClosedPublic
Actions

Authored by vkrause on Feb 21 2020, 4:42 PM.

Details

Reviewers
apol
Maniphest Tasks
T12520: Qt 5.14
Commits
R249:91c5e2ff604e: Support Qt 5.14 on Android
Summary

With Qt 5.14 asset files are no longer extracted into the filesystem, they
are only available via assert: or qrc: URLs. Those however aren't supported
by libintl, so copy catalogs to the cache folder on demand.

Not ideal (libintl using the assert manager NDK API directly would probably
be more efficient), but it's still better than 5.13, as unused catalogs
aren't copied.

Diff Detail

Repository
R249 KI18n
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Feb 21 2020, 4:42 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 21 2020, 4:42 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
vkrause requested review of this revision.Feb 21 2020, 4:42 PM
apol accepted this revision.Feb 21 2020, 5:35 PM
apol added a subscriber: apol.
apol added inline comments.
src/kcatalog.cpp
121

#if defined(Q_OS_ANDROID) && QT_VERSION >= QT_VERSION_CHECK(5, 14, 0)

This revision is now accepted and ready to land.Feb 21 2020, 5:35 PM
vkrause updated this revision to Diff 76160.Feb 22 2020, 11:12 AM

Improve compile-time conditional to only build the new code with Qt >= 5.14.

Closed by commit R249:91c5e2ff604e: Support Qt 5.14 on Android (authored by vkrause). · Explain WhyFeb 22 2020, 11:21 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kcatalog.cpp (33 lines)

Diff 76161

View Options

src/kcatalog.cpp

Loading...