Add XdgOutputV1 version 2
ClosedPublic
Actions

Authored by davidedmundson on Feb 21 2020, 1:04 AM.

Details

Reviewers

zzag

Group Reviewers

KWin

Commits

R127:8b355825a3b8: Add XdgOutputV1 version 2

Summary

Will be useful for making plasma widgets not move about
on multi monitor. QtWayland already supports it

Test Plan

Unit test

Repository

R127 KWayland

Branch

master

Lint

Lint Errors

Excuse: asdf

Severity	Location	Code	Message
Error	src/client/datadevicemanager.h:76	Cppcheck	unknownMacro
Error	src/client/output.h:97	Cppcheck	unknownMacro
Error	src/client/output.h:97	Cppcheck	unknownMacro

Unit

No Unit Test Coverage

Build Status

Buildable 22734
Build 22752: arc lint + arc unit

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

update

+1 LGTM

src/server/xdgoutput_interface.cpp
319	noob question: what would happen if you didn't have this check?

This revision is now accepted and ready to land.Feb 21 2020, 8:11 AM

src/server/xdgoutput_interface.cpp
319	If a client that only knew version1 connected and we sent this event, the client would raise a protocol error and quit.

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			autotests/client/test_xdg_output.cpp (10 lines)
M			src/client/registry.cpp (2 lines)
M			src/client/xdgoutput.h (14 lines)
M			src/client/xdgoutput.cpp (38 lines)
M			src/server/xdgoutput_interface.h (26 lines)
M			src/server/xdgoutput_interface.cpp (40 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	76076	a2d0920		Feb 21 2020, 1:04 AM	★	★
Diff 2	76077	a2d0920	update	Feb 21 2020, 1:05 AM	★	★
Diff 3	78345	8032cb0	R127:8b355825a3b83d906f79cb2bd929faa38e98a482	Mar 24 2020, 10:50 AM	★	★